Overlay in column_info

[mxposed]

I am trying to implement minimal example from https://funkyheatmap.github.io/examples/minimal/
and I noticed that text on rects is printed with overlay behavior in column info

Specifically, row 15 specifies text to be rendered with overlay=TRUE, so it is on top of previous position of row 14.

I wonder if this is a good way to define what we want and if I should implement it like as is?

I would propose an alternative to have flexible options parameter in column_info to cover such things, i.e. print value inside geom from this column. One benefit would be that this will allow to shrink text to geom.

What do you think? @rcannood @LouiseDck @artuurC

[rcannood]

I think that makes total sense. I think this is related to funkyheatmap/funkyheatmap#9, in a sense.

I propose changing the column_info as follows:

• size: changes the size of the geom
• colour: changes the fill of the geom
• label: plots a label on top of the geom (in which case we wouldn't need the overlay=TRUE anymore)
• hover_text: render this text when hovering over an element (JS only)

For backwards compatibility reasons, specifying the id automatically uses it to set the size and colour (and maybe hover_text in JS?). Except for rectangles, which only change colour, by default.

[mxposed]

I have implemented id_size, id_color, id_label and id_hover_text logic in #25

However, maybe we still need the overlay functionality, because currently I think there's no way to reproduce this https://funkyheatmap.github.io/funkyheatmap/articles/dynbenchmark.html with the Off the shelf label in QC category columns