[BUG] Local upscale missing initial image

[fszontagh]

On local image upscale, the initial image is not copied from the source image:

[iwr-redmond]

I don't know the code well at all, but looking at src/ui/MainWindow.cpp#L669 I would have assumed that the source image wouldn't be sd_cpp_gui_blankimage_png_to_wx_bitmap(). Is that the source of this error?

There doesn't appear to be anything obviously wrong about the design of the actual upscale logic (extprocess/src/ApplicationLogic.cpp#L407).

[fszontagh]

The MainWindow.cpp and the MainWindow.h files are generated with the wxFormBuilder, i never edit these files by hands.

The sd_cpp_gui_blankimage_png_to_wx_bitmap() function stores a placeholder image only.

The upscaling is works fine, this is 'just' a cosmetics issue. When the app gathering the infos for / from the queue job, the source image not copied into the jobs's files, but the placeholder image contains the valid filename. (in debug builds, a tooltip shows the full image paths and more infos)

The source image always copied into the output folder with the same name as the generated image name, eg. if the upscaled image name is upscale_1742486913_42_512x512.png then the source image name will be upscale_1742486913_42_512x512_initial.png

There is a "main" method to gather the infos for a queue job, it's name is the onGenerate. But i think this part is fine.

The handleSdImages method responsible for prepare the images to display in the UI (caching, resizing, collecting missing images from server etc.. ). So something is not okay there. On the last prerelease i refactored this part to fit with the server component.

[fszontagh]

Oh, i didn't realized, but this is another bug.

The upscaled image's name isupscale_1742486913_42_512x512.png which is wrong... The resolution in the filename is very wrong.