Op::DrawRectangle doesn't work

[tower120]

Maybe I am missing something, but I can't make Op::DrawRectangle work.
I don't see it in examples and tests.

Document processed and saved without warnings. But I don't see rectangle, when I open pdf with Acrobat.

I use it like this

        self.ops.push(Op::DrawRectangle { rectangle: Rect {
            x: Pt(50.0),
            y: Pt(50.0),
            width: Pt(20.0),
            height: Pt(20.0),
            mode: Some(PaintMode::Stroke),
            winding_order: Some(WindingOrder::NonZero),  // I tried None as well
        } });

While line and polygon works fine.

[Pironium-dev]

I've investigated this issue with the help of an AI coding assistant and identified the root cause.

Root Cause:

In src/serialize.rs, the rectangle_to_stream_ops function ignores the "mode" field of Rect entirely. It always ends the path with the n operator (end path without painting), regardless of what PaintMode is set:

fn rectangle_to_stream_ops(rectangle: &crate::Rect) -> Vec<LoOp> {
    operations.push(LoOp::new("re", vec![...])); // defines the rectangle path
    // W / W* for clipping
    operations.push(LoOp::new("n", vec![])); // ← always discards the path!
}

In contrast, polygon_to_stream_ops correctly handles "mode" by emitting the appropriate PDF painting operators (f/S/B etc.) based on PaintMode.

Proposed Fix:

Add a match on rectangle.mode before closing the path, similar to how polygon_to_stream_ops handles it:

match rectangle.mode {
    Some(PaintMode::Fill) => { /* emit fill operator */ }
    Some(PaintMode::Stroke) => { operations.push(LoOp::new("S", vec![])); }
    Some(PaintMode::FillStroke) => { /* emit fill+stroke operator */ }
    Some(PaintMode::Clip) | None => { operations.push(LoOp::new("n", vec![])); }
}

Workaround:

Until this is fixed, using Op::DrawPolygon with four corner points instead of Op::DrawRectangle works correctly, since polygon_to_stream_ops properly respects PaintMode.

I wanted to submit a PR for this fix, but I couldn't build the forked repository locally, so I'm sharing the analysis here instead. I hope this helps anyone who wants to pick it up.