[FIX] Batch bot review findings — CodeRabbit + cubic cleanup

[four-bytes-robby]

Purpose

Catch-all issue for outstanding CodeRabbit and cubic-dev-ai findings not yet addressed. Fix each finding individually in this branch, leave issue open for future bot findings to be added.

Findings

1. file-tree.test.ts — Vacuous symlink assertion (CodeRabbit, PR #42)

File: tests/file-tree.test.ts lines 107-121
Finding: The test "skips symlinked directories to prevent cycles" has a misleading comment ("symlink dir itself may appear") and a vacuous if (link) check. Since the implementation skips symlinks entirely (lstatSync + isSymbolicLink()), link is always undefined, and the assertion never executes.
Fix: Replace with expect(link).toBeUndefined() and remove misleading comment.

Acceptance

• Finding 1 fixed and verified

---

Add new findings below this line as they come in from bot reviews.

[coderabbitai]

🔗 Related PRs

#15 - feat/14 append file tool [merged]
#25 - feat: add gh_bot_review tool to parse AI bot findings #22 [merged]
#39 - fix: smart_edit — add output field, Claude-style diff, normalization typo #38 [merged]
#41 - fix: batch — 12 cubic findings from PR #36 #40 [merged]
#42 - fix: batch — 12 cubic findings from PR #36 + file-tree hardening #40 [closed]

---

📝 Issue Planner

_{Check the box below or use the @coderabbitai plan command to generate an implementation plan and prompts that you can use with your favorite coding assistant.}

• Create Plan

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord!