Skip to content

fix: batch — 12 cubic findings from PR #36 #40

Description

@four-bytes-robby

Post-merge batch fix for 12 unresolved cubic findings from PR #36.

P1:

  • batch-patch.ts: '' sentinel deletes valid empty files on rollback
  • smart-patch.ts: mixed hunks lose context lines on splice

P2:

  • smart-edit.ts: old_string not validated as non-empty
  • solution-confidence.ts: run_tests result parsing missing guard
  • solution-confidence.ts: score can exceed 1.0 via redistribution
  • research.ts: query elements not validated as strings
  • research.ts: scope not validated
  • file-tree.ts: glob regex doesn't escape special chars
  • tests/smart-patch.test.ts: 2x missing await on .rejects.toThrow()
  • tests/file-tree.test.ts: missing await on .rejects.toThrow()

Docs:

  • file-tree.ts: .gitignore claim in description, never implemented

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions