From ac5df07705407d79939613400b5f9b64c438a00b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1s=20Castillo?= Date: Fri, 7 Aug 2026 15:35:02 -0300 Subject: [PATCH 1/2] fix: replace authErrorHandler for snackbarErrorHandler to fix zindex issue on errors MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Tomás Castillo --- src/actions/inventory-item-actions.js | 34 ++++++++++--------------- src/actions/inventory-shared-actions.js | 24 ++++++++--------- 2 files changed, 26 insertions(+), 32 deletions(-) diff --git a/src/actions/inventory-item-actions.js b/src/actions/inventory-item-actions.js index 9a7fa66ca..99dae7462 100644 --- a/src/actions/inventory-item-actions.js +++ b/src/actions/inventory-item-actions.js @@ -20,12 +20,10 @@ import { createAction, stopLoading, startLoading, - showMessage, - showSuccessMessage, - authErrorHandler, + snackbarSuccessHandler, + snackbarErrorHandler, escapeFilterValue } from "openstack-uicore-foundation/lib/utils/actions"; -import history from "../history"; import { getAccessTokenSafely } from "../utils/methods"; import { DEFAULT_CURRENT_PAGE, @@ -139,7 +137,7 @@ export const getInventoryItems = createAction(REQUEST_INVENTORY_ITEMS), createAction(RECEIVE_INVENTORY_ITEMS), `${window.INVENTORY_API_BASE_URL}/api/v1/inventory-items`, - authErrorHandler, + snackbarErrorHandler, { order, orderDir, page, perPage, term, showArchived } )(params)(dispatch).then(() => { dispatch(stopLoading()); @@ -160,7 +158,7 @@ export const getInventoryItem = (inventoryItemId) => async (dispatch) => { null, createAction(RECEIVE_INVENTORY_ITEM), `${window.INVENTORY_API_BASE_URL}/api/v1/inventory-items/${inventoryItemId}`, - authErrorHandler + snackbarErrorHandler )(params)(dispatch).then(() => { dispatch(stopLoading()); }); @@ -180,7 +178,7 @@ export const deleteInventoryItem = (inventoryItemId) => async (dispatch) => { createAction(INVENTORY_ITEM_DELETED)({ inventoryItemId }), `${window.INVENTORY_API_BASE_URL}/api/v1/inventory-items/${inventoryItemId}`, null, - authErrorHandler + snackbarErrorHandler )(params)(dispatch).then(() => { dispatch(stopLoading()); }); @@ -219,7 +217,7 @@ export const saveInventoryItem = (entity) => async (dispatch) => { createAction(INVENTORY_ITEM_UPDATED), `${window.INVENTORY_API_BASE_URL}/api/v1/inventory-items/${entity.id}`, normalizedEntity, - authErrorHandler, + snackbarErrorHandler, entity )(params)(dispatch) .then(() => { @@ -235,9 +233,10 @@ export const saveInventoryItem = (entity) => async (dispatch) => { return Promise.all(promises).then(() => { dispatch( - showSuccessMessage( - T.translate("edit_inventory_item.inventory_item_saved") - ) + snackbarSuccessHandler({ + title: T.translate("general.success"), + html: T.translate("edit_inventory_item.inventory_item_saved") + }) ); }); }) @@ -250,18 +249,12 @@ export const saveInventoryItem = (entity) => async (dispatch) => { }); } - const success_message = { - title: T.translate("general.done"), - html: T.translate("edit_inventory_item.inventory_item_created"), - type: "success" - }; - return postRequest( createAction(ADD_INVENTORY_ITEM), createAction(INVENTORY_ITEM_ADDED), `${window.INVENTORY_API_BASE_URL}/api/v1/inventory-items`, normalizedEntity, - authErrorHandler, + snackbarErrorHandler, entity )(params)(dispatch) .then(({ response }) => { @@ -278,8 +271,9 @@ export const saveInventoryItem = (entity) => async (dispatch) => { return Promise.all(promises).then(() => { dispatch( - showMessage(success_message, () => { - history.push("/app/inventory"); + snackbarSuccessHandler({ + title: T.translate("general.done"), + html: T.translate("edit_inventory_item.inventory_item_created") }) ); }); diff --git a/src/actions/inventory-shared-actions.js b/src/actions/inventory-shared-actions.js index 64de746a7..32ee3ba88 100644 --- a/src/actions/inventory-shared-actions.js +++ b/src/actions/inventory-shared-actions.js @@ -18,7 +18,7 @@ import { createAction, stopLoading, startLoading, - authErrorHandler + snackbarErrorHandler } from "openstack-uicore-foundation/lib/utils/actions"; import { getAccessTokenSafely } from "../utils/methods"; @@ -68,7 +68,7 @@ export const saveMetaFieldTypes = createAction(settings.updatedActionName), `${settings.url}/${metaFieldType.id}`, normalizedEntity, - authErrorHandler, + snackbarErrorHandler, metaFieldType )(params)(dispatch).then(() => { if ( @@ -88,7 +88,7 @@ export const saveMetaFieldTypes = createAction(settings.addedActionName), settings.url, normalizedEntity, - authErrorHandler, + snackbarErrorHandler, metaFieldType )(params)(dispatch).then(({ response }) => { if ( @@ -129,7 +129,7 @@ export const deleteMetaFieldType = createAction(settings.deletedActionName)({ metaFieldId }), `${settings.url}/${metaFieldId}`, null, - authErrorHandler + snackbarErrorHandler )(params)(dispatch).then(() => { dispatch(stopLoading()); }); @@ -168,7 +168,7 @@ export const saveMetaFieldValues = createAction(settings.updatedActionName), `${settings.url}/${value.id}`, normalizedEntity, - authErrorHandler, + snackbarErrorHandler, value )(params)(dispatch); } else { @@ -177,7 +177,7 @@ export const saveMetaFieldValues = createAction(settings.addedActionName), settings.url, normalizedEntity, - authErrorHandler, + snackbarErrorHandler, value )(params)(dispatch); } @@ -209,7 +209,7 @@ export const deleteMetaFieldTypeValue = }), `${settings.url}${valueId}`, null, - authErrorHandler + snackbarErrorHandler )(params)(dispatch).then(() => { dispatch(stopLoading()); }); @@ -236,7 +236,7 @@ export const saveFiles = createAction(settings.updatedActionName), `${settings.url}${file.id}/`, file, - authErrorHandler, + snackbarErrorHandler, file )(params)(dispatch); } @@ -245,7 +245,7 @@ export const saveFiles = createAction(settings.addedActionName), settings.url, file, - authErrorHandler, + snackbarErrorHandler, file )(params)(dispatch); }); @@ -275,7 +275,7 @@ export const deleteFile = createAction(settings.deletedActionName)({ fileId }), `${settings.url}/${fileId}`, null, - authErrorHandler + snackbarErrorHandler )(params)(dispatch).then(() => { dispatch(stopLoading()); }); @@ -294,7 +294,7 @@ export const archiveItem = createAction(settings.updatedActionName), `${settings.url}`, item, - authErrorHandler, + snackbarErrorHandler, item )(params)(dispatch); }; @@ -312,7 +312,7 @@ export const unarchiveItem = createAction(settings.deletedActionName)(item.id), `${settings.url}`, null, - authErrorHandler, + snackbarErrorHandler, item )(params)(dispatch).then(() => { dispatch(stopLoading()); From b3071d2a8527014a9b3468cfdcca82e97ed5dba4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1s=20Castillo?= Date: Fri, 7 Aug 2026 16:46:45 -0300 Subject: [PATCH 2/2] fix: add error throw on promises at save metafields MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Tomás Castillo --- src/actions/inventory-shared-actions.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/actions/inventory-shared-actions.js b/src/actions/inventory-shared-actions.js index 32ee3ba88..69da56874 100644 --- a/src/actions/inventory-shared-actions.js +++ b/src/actions/inventory-shared-actions.js @@ -104,6 +104,7 @@ export const saveMetaFieldTypes = return Promise.all(promises).catch((err) => { console.error(err); + throw err; }); };