Skip to content

Arrows gets twice position:absolute #44

@dilyanpalauzov

Description

@dilyanpalauzov

https://popper.js.org/docs/v2/tutorial/#arrow suggests this call:

<div id="tooltip" role="tooltip">
  My tooltip
  <div id="arrow" data-popper-arrow></div>
</div>

and

#arrow,
#arrow::before {
  position: absolute;
  width: 8px;
  height: 8px;
  background: inherit;
}

As far as I can see, the arrow modified assigns the element with id="arrow" to state.elements.arrow. The appyStyles modifier sets state.elements.arrow.style.position='absolute'.

This means, that by following the tutorial the position style for the arrow-element is set twice to absolute: once using CSS and once by Javascript.

Please adjust either the tutorial, not to recommend setting explictly #arrow, #arrow::before { position: absolute }, or the arrow/applyStyle modifiers not to set for the arrow-element position: absolute.

E.g. the example shall set position: absolute for #arrow::before, but not for #arrow itself.

Moved from floating-ui/floating-ui#1528.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions