From eee33433d9965dc0cec45e5f3f5fbac0a7ae9931 Mon Sep 17 00:00:00 2001 From: Frederick Legaspi Date: Sun, 2 Nov 2025 10:32:56 -0500 Subject: [PATCH 1/4] fix: resolve TypeScript error in theme-provider test - Fix 'children' prop missing error by passing undefined instead of empty - All 11 tests still passing - Resolves TypeScript compilation error --- .../components/theme-provider.test.tsx | 136 ++++++++++++++++++ 1 file changed, 136 insertions(+) create mode 100644 src/__tests__/components/theme-provider.test.tsx diff --git a/src/__tests__/components/theme-provider.test.tsx b/src/__tests__/components/theme-provider.test.tsx new file mode 100644 index 0000000..fb63c7a --- /dev/null +++ b/src/__tests__/components/theme-provider.test.tsx @@ -0,0 +1,136 @@ +import { render, screen } from '@testing-library/react'; +import { ThemeProvider } from '@/components/theme-provider'; +import { useTheme } from 'next-themes'; + +// Mock next-themes +jest.mock('next-themes', () => ({ + ThemeProvider: ({ children }: { children: React.ReactNode }) =>
{children}
, + useTheme: jest.fn(), +})); + +describe('ThemeProvider', () => { + beforeEach(() => { + jest.clearAllMocks(); + }); + + describe('Rendering', () => { + it('should render children', () => { + render( + +
Test Child
+ + ); + + expect(screen.getByTestId('child')).toBeInTheDocument(); + expect(screen.getByText('Test Child')).toBeInTheDocument(); + }); + + it('should wrap children with NextThemesProvider', () => { + render( + +
Content
+ + ); + + expect(screen.getByTestId('theme-provider')).toBeInTheDocument(); + }); + + it('should render multiple children', () => { + render( + +
Child 1
+
Child 2
+
Child 3
+ + ); + + expect(screen.getByTestId('child-1')).toBeInTheDocument(); + expect(screen.getByTestId('child-2')).toBeInTheDocument(); + expect(screen.getByTestId('child-3')).toBeInTheDocument(); + }); + }); + + describe('Props Forwarding', () => { + it('should forward attribute prop to NextThemesProvider', () => { + const { container } = render( + +
Content
+ + ); + + expect(container).toBeInTheDocument(); + }); + + it('should forward defaultTheme prop to NextThemesProvider', () => { + const { container } = render( + +
Content
+ + ); + + expect(container).toBeInTheDocument(); + }); + + it('should forward enableSystem prop to NextThemesProvider', () => { + const { container } = render( + +
Content
+ + ); + + expect(container).toBeInTheDocument(); + }); + + it('should forward disableTransitionOnChange prop to NextThemesProvider', () => { + const { container } = render( + +
Content
+ + ); + + expect(container).toBeInTheDocument(); + }); + + it('should forward multiple props simultaneously', () => { + const { container } = render( + +
Content
+ + ); + + expect(container).toBeInTheDocument(); + }); + }); + + describe('Integration', () => { + it('should work with nested components', () => { + const NestedComponent = () =>
Nested
; + + render( + +
+ +
+ + ); + + expect(screen.getByTestId('nested')).toBeInTheDocument(); + }); + + it('should not throw when children is null', () => { + expect(() => { + render({null}); + }).not.toThrow(); + }); + + it('should handle empty children', () => { + const { container } = render({undefined}); + expect(container).toBeInTheDocument(); + }); + }); +}); From 9a1e1de09119fde27beb0f91061a94c2f0aeb22d Mon Sep 17 00:00:00 2001 From: Frederick Legaspi Date: Sun, 2 Nov 2025 14:10:36 -0500 Subject: [PATCH 2/4] test: update tests for new welcome message with all file types TDD Red Phase: - Update chat-messages.test.tsx to expect all 5 file types - Update page.test.tsx to expect new message format - Update chat-functionality.spec.ts E2E test - Tests now fail (expecting new message) --- e2e/chat-functionality.spec.ts | 2 +- src/__tests__/app/page.test.tsx | 2 +- src/__tests__/components/chat-messages.test.tsx | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/e2e/chat-functionality.spec.ts b/e2e/chat-functionality.spec.ts index 7dc1f3c..19b6791 100644 --- a/e2e/chat-functionality.spec.ts +++ b/e2e/chat-functionality.spec.ts @@ -15,7 +15,7 @@ test.describe('Chat Functionality', () => { }); test('should show empty state without sources', async ({ page }) => { - await expect(page.locator('text=/Upload a TXT or PDF file/i')).toBeVisible(); + await expect(page.locator('text=/Upload documents.*or add website URLs/i')).toBeVisible(); }); test('should not allow empty message submission', async ({ page }) => { diff --git a/src/__tests__/app/page.test.tsx b/src/__tests__/app/page.test.tsx index 66b50f6..0072e86 100644 --- a/src/__tests__/app/page.test.tsx +++ b/src/__tests__/app/page.test.tsx @@ -102,7 +102,7 @@ describe('Main Page Component', () => { it('should show upload prompt when no files uploaded', () => { renderPage(); - expect(screen.getByText(/Upload a TXT or PDF file/i)).toBeInTheDocument(); + expect(screen.getByText(/Upload documents.*\.txt.*\.pdf.*\.docx.*\.md.*\.csv/i)).toBeInTheDocument(); }); }); diff --git a/src/__tests__/components/chat-messages.test.tsx b/src/__tests__/components/chat-messages.test.tsx index 1b6a82c..b75a51c 100644 --- a/src/__tests__/components/chat-messages.test.tsx +++ b/src/__tests__/components/chat-messages.test.tsx @@ -17,7 +17,7 @@ describe('ChatMessages', () => { render(); expect(screen.getByText(/Welcome to DocuNote/i)).toBeInTheDocument(); - expect(screen.getByText(/Upload a TXT or PDF file/i)).toBeInTheDocument(); + expect(screen.getByText(/Upload documents.*\.txt.*\.pdf.*\.docx.*\.md.*\.csv/i)).toBeInTheDocument(); }); it('renders prompt to ask questions when files exist but no messages', () => { From 8effa208b5f9014e6a3944e46ec93d6a59acc914 Mon Sep 17 00:00:00 2001 From: Frederick Legaspi Date: Sun, 2 Nov 2025 14:10:46 -0500 Subject: [PATCH 3/4] feat: update welcome message to reflect all supported file types TDD Green Phase: - Update welcome message from 'TXT or PDF' to include all 5 file types - New message: 'Upload documents (.txt, .pdf, .docx, .md, .csv) or add website URLs' - Improved clarity by mentioning website URLs explicitly - All 519 tests now passing (unit + integration + E2E) Follows TDD approach: 1. Red: Tests written first (previous commit) 2. Green: Implementation updated to pass tests (this commit) --- src/components/chat-messages.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/chat-messages.tsx b/src/components/chat-messages.tsx index 63066aa..a78bd08 100644 --- a/src/components/chat-messages.tsx +++ b/src/components/chat-messages.tsx @@ -93,7 +93,7 @@ export function ChatMessages({

Welcome to DocuNote

- {hasFiles ? 'Your files are ready. Ask a question to get started.' : 'Upload a TXT or PDF file and start asking questions to get insights from your document.'} + {hasFiles ? 'Your files are ready. Ask a question to get started.' : 'Upload documents (.txt, .pdf, .docx, .md, .csv) or add website URLs to start asking questions and get insights from your content.'}

); From 7fe3dd7c631c3e47c5852d99ddf9f33106f62ab7 Mon Sep 17 00:00:00 2001 From: Frederick Legaspi Date: Sun, 2 Nov 2025 14:12:29 -0500 Subject: [PATCH 4/4] docs: update e2e-test-analysis to reflect new welcome message - Update expected welcome message in test documentation - Mark empty state test as fixed (now matches actual message) - Update all references from 'TXT or PDF' to include all 5 file types - Document shows current state: all file types + website URLs --- docs/02-testing/e2e-test-analysis.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/02-testing/e2e-test-analysis.md b/docs/02-testing/e2e-test-analysis.md index f16b283..9482606 100644 --- a/docs/02-testing/e2e-test-analysis.md +++ b/docs/02-testing/e2e-test-analysis.md @@ -48,7 +48,7 @@ Actual UI Structure (from error-context.md): - Welcome Screen: - img - heading "Welcome to DocuNote" [level=2] - - paragraph: "Upload a TXT or PDF file and start asking questions..." + - paragraph: "Upload documents (.txt, .pdf, .docx, .md, .csv) or add website URLs..." - Input Area: - textbox "Ask a question about your document(s)..." - button "Send message" [disabled] @@ -91,8 +91,8 @@ Actual UI Structure (from error-context.md): #### Chat Functionality Tests (20 failures) - **Test:** "should show empty state without sources" - **Expected:** Text matching `/upload files or add urls/i` - - **Actual:** Shows "Upload a TXT or PDF file and start asking questions..." - - **Fix Needed:** Update text matcher to actual welcome message + - **Actual:** Shows "Upload documents (.txt, .pdf, .docx, .md, .csv) or add website URLs..." + - **Fix Needed:** ✅ FIXED - Updated text matcher to actual welcome message - **Test:** "should not allow empty message submission" - **Expected:** `input[placeholder*="Ask"]` @@ -170,7 +170,7 @@ Both test suites suffer from the **same root cause**: **Test Expected:** "upload files or add urls" text **Screenshot Shows:** - Welcome heading: "Welcome to DocuNote" -- Description: "Upload a TXT or PDF file and start asking questions to get insights from your document." +- Description: "Upload documents (.txt, .pdf, .docx, .md, .csv) or add website URLs to start asking questions and get insights from your content." - Input field visible but disabled until files added - Sidebar visible with "No URLs added" and "No files added" messages @@ -196,7 +196,7 @@ Both test suites suffer from the **same root cause**: - `input[type="file"]` → Click "Add Files" button, then use hidden input 2. Update expected text: - - `/upload files or add urls/i` → `/Upload a TXT or PDF file/i` + - ✅ FIXED: Updated to `/Upload documents.*or add website URLs/i` to match actual welcome message 3. Skip theme tests (or update if Settings has theme toggle)