Skip to content

fix: unified exceptions and error handling patterns #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
casc84ab merged 1 commit into from
Feb 13, 2026
Merged

fix: unified exceptions and error handling patterns #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions plugin-api/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,13 @@

<name>Firefly Framework - Plugin API</name>
<description>Core API and interfaces for the Firefly plugin system</description>

<dependencies>
<!-- Firefly Kernel (foundational: exceptions, shared abstractions) -->
<dependency>
<groupId>org.fireflyframework</groupId>
<artifactId>fireflyframework-kernel</artifactId>
<version>${project.version}</version>
</dependency>
</dependencies>
</project>
4 changes: 3 additions & 1 deletion plugin-api/src/main/java/org/fireflyframework/plugin/api/PluginException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,12 @@

package org.fireflyframework.plugin.api;

import org.fireflyframework.kernel.exception.FireflyException;

/**
* Base exception for plugin-related errors.
*/
public class PluginException extends Exception {
public class PluginException extends FireflyException {

public PluginException(String message) {
super(message);
Expand Down
8 changes: 4 additions & 4 deletions plugin-core/src/main/java/org/fireflyframework/plugin/core/DefaultExtensionRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
*/
public class DefaultExtensionRegistry implements ExtensionRegistry {

private static final Logger logger = LoggerFactory.getLogger(DefaultExtensionRegistry.class);
private static final Logger log = LoggerFactory.getLogger(DefaultExtensionRegistry.class);

private final Map<String, Class<?>> extensionPoints = new ConcurrentHashMap<>();
private final Map<String, List<ExtensionEntry<?>>> extensions = new ConcurrentHashMap<>();
Expand All @@ -40,7 +40,7 @@ public <T> void registerExtensionPoint(String extensionPointId, Class<T> extensi
Objects.requireNonNull(extensionPointId, "Extension point ID cannot be null");
Objects.requireNonNull(extensionPointClass, "Extension point class cannot be null");

logger.info("Registering extension point: {} -> {}", extensionPointId, extensionPointClass.getName());
log.info("Registering extension point: {} -> {}", extensionPointId, extensionPointClass.getName());
extensionPoints.put(extensionPointId, extensionPointClass);
extensions.putIfAbsent(extensionPointId, new CopyOnWriteArrayList<>());
}
Expand All @@ -62,7 +62,7 @@ public <T> void registerExtension(String extensionPointId, T extension, int prio
);
}

logger.info("Registering extension {} for extension point {} with priority {}",
log.info("Registering extension {} for extension point {} with priority {}",
extension.getClass().getSimpleName(), extensionPointId, priority);

List<ExtensionEntry<?>> extensionList = extensions.computeIfAbsent(
Expand All @@ -82,7 +82,7 @@ public <T> void unregisterExtension(String extensionPointId, T extension) {
Objects.requireNonNull(extensionPointId, "Extension point ID cannot be null");
Objects.requireNonNull(extension, "Extension cannot be null");

logger.info("Unregistering extension {} from extension point {}",
log.info("Unregistering extension {} from extension point {}",
extension.getClass().getSimpleName(), extensionPointId);

List<ExtensionEntry<?>> extensionList = extensions.get(extensionPointId);
Expand Down
38 changes: 19 additions & 19 deletions plugin-core/src/main/java/org/fireflyframework/plugin/core/DefaultPluginManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
*/
public class DefaultPluginManager implements PluginManager {

private static final Logger logger = LoggerFactory.getLogger(DefaultPluginManager.class);
private static final Logger log = LoggerFactory.getLogger(DefaultPluginManager.class);

private final Map<String, Plugin> plugins = new ConcurrentHashMap<>();
private final Map<String, PluginDescriptor> descriptors = new ConcurrentHashMap<>();
Expand All @@ -57,11 +57,11 @@ public DefaultPluginManager(ExtensionRegistry extensionRegistry) {
@Override
public synchronized void initialize() throws PluginException {
if (initialized) {
logger.warn("Plugin manager already initialized");
log.warn("Plugin manager already initialized");
return;
}

logger.info("Initializing plugin manager");
log.info("Initializing plugin manager");
initialized = true;
}

Expand All @@ -83,7 +83,7 @@ public PluginDescriptor loadPlugin(Class<? extends Plugin> pluginClass) throws P
throw new PluginException("Plugin already loaded: " + pluginId);
}

logger.info("Loading plugin: {} ({})", metadata.name(), pluginId);
log.info("Loading plugin: {} ({})", metadata.name(), pluginId);

// Create descriptor
PluginDescriptor descriptor = PluginDescriptor.builder()
Expand All @@ -100,7 +100,7 @@ public PluginDescriptor loadPlugin(Class<? extends Plugin> pluginClass) throws P
plugin.initialize();
descriptor = descriptor.withState(PluginState.INITIALIZED);
descriptors.put(pluginId, descriptor);
logger.info("Plugin initialized: {}", pluginId);
log.info("Plugin initialized: {}", pluginId);
} catch (Exception e) {
descriptor = descriptor.withState(PluginState.FAILED);
descriptors.put(pluginId, descriptor);
Expand Down Expand Up @@ -130,7 +130,7 @@ public void startPlugin(String pluginId) throws PluginException {

PluginDescriptor descriptor = descriptors.get(pluginId);
if (descriptor.state() == PluginState.STARTED) {
logger.warn("Plugin already started: {}", pluginId);
log.warn("Plugin already started: {}", pluginId);
return;
}

Expand All @@ -150,13 +150,13 @@ public void startPlugin(String pluginId) throws PluginException {
throw new PluginException("Failed to resolve dependencies for plugin: " + pluginId, e);
}

logger.info("Starting plugin: {}", pluginId);
log.info("Starting plugin: {}", pluginId);

try {
plugin.start();
descriptor = descriptor.withState(PluginState.STARTED);
descriptors.put(pluginId, descriptor);
logger.info("Plugin started: {}", pluginId);
log.info("Plugin started: {}", pluginId);
} catch (Exception e) {
descriptor = descriptor.withState(PluginState.FAILED);
descriptors.put(pluginId, descriptor);
Expand All @@ -175,17 +175,17 @@ public void stopPlugin(String pluginId) throws PluginException {

PluginDescriptor descriptor = descriptors.get(pluginId);
if (descriptor.state() != PluginState.STARTED) {
logger.warn("Plugin not started: {}", pluginId);
log.warn("Plugin not started: {}", pluginId);
return;
}

logger.info("Stopping plugin: {}", pluginId);
log.info("Stopping plugin: {}", pluginId);

try {
plugin.stop();
descriptor = descriptor.withState(PluginState.STOPPED);
descriptors.put(pluginId, descriptor);
logger.info("Plugin stopped: {}", pluginId);
log.info("Plugin stopped: {}", pluginId);
} catch (Exception e) {
descriptor = descriptor.withState(PluginState.FAILED);
descriptors.put(pluginId, descriptor);
Expand All @@ -209,7 +209,7 @@ public void unloadPlugin(String pluginId) throws PluginException {
stopPlugin(pluginId);
}

logger.info("Unloading plugin: {}", pluginId);
log.info("Unloading plugin: {}", pluginId);

try {
// Unregister extensions
Expand All @@ -222,7 +222,7 @@ public void unloadPlugin(String pluginId) throws PluginException {
plugins.remove(pluginId);
descriptors.remove(pluginId);

logger.info("Plugin unloaded: {}", pluginId);
log.info("Plugin unloaded: {}", pluginId);
} catch (Exception e) {
throw new PluginException("Failed to unload plugin: " + pluginId, e);
}
Expand Down Expand Up @@ -254,15 +254,15 @@ public synchronized void shutdown() throws PluginException {
return;
}

logger.info("Shutting down plugin manager");
log.info("Shutting down plugin manager");

// Stop and unload all plugins
List<String> pluginIds = new ArrayList<>(plugins.keySet());
for (String pluginId : pluginIds) {
try {
unloadPlugin(pluginId);
} catch (Exception e) {
logger.error("Error unloading plugin during shutdown: {}", pluginId, e);
log.error("Error unloading plugin during shutdown: {}", pluginId, e);
}
}

Expand All @@ -285,10 +285,10 @@ private void registerPluginExtensions(Plugin plugin, Class<?> pluginClass) {
extension,
annotation.priority()
);
logger.debug("Registered extension {} for plugin {}",
log.debug("Registered extension {} for plugin {}",
innerClass.getSimpleName(), plugin.getMetadata().id());
} catch (Exception e) {
logger.error("Failed to register extension: {}", innerClass.getName(), e);
log.error("Failed to register extension: {}", innerClass.getName(), e);
}
}
}
Expand All @@ -308,10 +308,10 @@ private void unregisterPluginExtensions(Plugin plugin, Class<?> pluginClass) {
annotation.extensionPointId(),
extension
);
logger.debug("Unregistered extension {} for plugin {}",
log.debug("Unregistered extension {} for plugin {}",
innerClass.getSimpleName(), plugin.getMetadata().id());
} catch (Exception e) {
logger.error("Failed to unregister extension: {}", innerClass.getName(), e);
log.error("Failed to unregister extension: {}", innerClass.getName(), e);
}
}
}
Expand Down