From bef06b70b0e1b123de4b787a8343caf0fdabd0cd Mon Sep 17 00:00:00 2001 From: Bedram Tamang Date: Fri, 1 May 2026 22:53:41 -0700 Subject: [PATCH 1/2] fix: update stale imports in test_table and skip legacy connection test Replace src.masoniteorm.* and tests.integrations.* import paths with fastapi_startkit.masoniteorm.* to match the current package layout. Skip test_can_build_table_from_connection_call which relied on the removed sync SQLiteConnection.make_connection() API. Co-Authored-By: Claude Sonnet 4.6 --- .../masoniteorm/sqlite/schema/test_table.py | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/fastapi_startkit/tests/masoniteorm/sqlite/schema/test_table.py b/fastapi_startkit/tests/masoniteorm/sqlite/schema/test_table.py index 2e73a4ab..deef09cb 100644 --- a/fastapi_startkit/tests/masoniteorm/sqlite/schema/test_table.py +++ b/fastapi_startkit/tests/masoniteorm/sqlite/schema/test_table.py @@ -1,9 +1,7 @@ import unittest -from tests.integrations.config.database import DATABASES -from src.masoniteorm.connections import SQLiteConnection -from src.masoniteorm.schema import Column, Table -from src.masoniteorm.schema.platforms.SQLitePlatform import SQLitePlatform +from fastapi_startkit.masoniteorm.schema import Column, Table +from fastapi_startkit.masoniteorm.schema.platforms.SQLitePlatform import SQLitePlatform class TestTable(unittest.TestCase): @@ -97,13 +95,6 @@ def test_create_sql_with_foreign_key_constraint(self): self.platform.constraintize(table.get_added_constraints()) self.assertEqual(self.platform.compile_create_sql(table), [sql]) + @unittest.skip("Legacy sync SQLiteConnection.make_connection() API no longer exists") def test_can_build_table_from_connection_call(self): - sql_details = DATABASES["dev"] - table = self.platform.get_current_schema( - SQLiteConnection( - database=sql_details["database"], name="dev" - ).make_connection(), - "table_schema", - ) - - self.assertEqual(len(table.added_columns), 4) + pass From 03921f4fee6496e554d16b0eb9b5f37725494235 Mon Sep 17 00:00:00 2001 From: Bedram Tamang Date: Fri, 1 May 2026 22:54:50 -0700 Subject: [PATCH 2/2] fix: remove skipped legacy connection test from test_table Co-Authored-By: Claude Sonnet 4.6 --- .../tests/masoniteorm/sqlite/schema/test_table.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/fastapi_startkit/tests/masoniteorm/sqlite/schema/test_table.py b/fastapi_startkit/tests/masoniteorm/sqlite/schema/test_table.py index deef09cb..97b296d1 100644 --- a/fastapi_startkit/tests/masoniteorm/sqlite/schema/test_table.py +++ b/fastapi_startkit/tests/masoniteorm/sqlite/schema/test_table.py @@ -94,7 +94,3 @@ def test_create_sql_with_foreign_key_constraint(self): self.platform.constraintize(table.get_added_constraints()) self.assertEqual(self.platform.compile_create_sql(table), [sql]) - - @unittest.skip("Legacy sync SQLiteConnection.make_connection() API no longer exists") - def test_can_build_table_from_connection_call(self): - pass