From 51c9d8407ac90481d8c0375b995feca9f3d6c39a Mon Sep 17 00:00:00 2001 From: Wei Su Date: Wed, 19 Aug 2026 13:21:37 -0700 Subject: [PATCH] Default the companion write sweep off (FEEDSIM_SWEEP_WN=0) Differential Revision: D116670440 --- .../feature_extractors/generated/extractor_helpers.cpp | 8 ++++---- .../feature_extractors/generated/extractor_helpers.h | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/feedsim/third_party/src/workloads/ranking/feature_extractors/generated/extractor_helpers.cpp b/packages/feedsim/third_party/src/workloads/ranking/feature_extractors/generated/extractor_helpers.cpp index 1dd9fff9d..f1a4f8573 100644 --- a/packages/feedsim/third_party/src/workloads/ranking/feature_extractors/generated/extractor_helpers.cpp +++ b/packages/feedsim/third_party/src/workloads/ranking/feature_extractors/generated/extractor_helpers.cpp @@ -382,10 +382,10 @@ void initSweep() { // Companion write sweep: the read sweep above only adds read traffic, which // leaves feedsim's read:write ratio above prod's. FEEDSIM_SWEEP_WN streaming // writes/call over a separate DRAM-resident buffer raise the write share to - // move the ratio toward prod. Default 16 is a balanced cross-platform value; - // set FEEDSIM_SWEEP_WN=0 to disable (skips buffer allocation). Write - // stride/size default to the read knobs. - g_sweep.wn = envInt("FEEDSIM_SWEEP_WN", 16); + // move the ratio toward prod. Default 0 disables the sweep (no-op, skips + // buffer allocation); set FEEDSIM_SWEEP_WN>0 to enable. Write stride/size + // default to the read knobs. + g_sweep.wn = envInt("FEEDSIM_SWEEP_WN", 0); if (g_sweep.wn < 0) { g_sweep.wn = 0; } diff --git a/packages/feedsim/third_party/src/workloads/ranking/feature_extractors/generated/extractor_helpers.h b/packages/feedsim/third_party/src/workloads/ranking/feature_extractors/generated/extractor_helpers.h index ecac9dbb8..589c5ec6b 100644 --- a/packages/feedsim/third_party/src/workloads/ranking/feature_extractors/generated/extractor_helpers.h +++ b/packages/feedsim/third_party/src/workloads/ranking/feature_extractors/generated/extractor_helpers.h @@ -137,9 +137,9 @@ float runStrideSweep(uint64_t seed); // separate buffer of FEEDSIM_SWEEP_WMB megabytes, stepping FEEDSIM_SWEEP_WSTRIDE // floats each write, to raise the write share of DRAM bandwidth toward prod's // read:write ratio. Streaming stores keep the traffic as pure writes (no -// read-for-ownership). Knobs are read once from the environment; the default 16 -// is a balanced cross-platform value, and FEEDSIM_SWEEP_WN=0 disables the -// sweep (no-op, skips buffer allocation). Write stride/size default to the read +// read-for-ownership). Knobs are read once from the environment; the default 0 +// disables the sweep (no-op, skips buffer allocation) and FEEDSIM_SWEEP_WN>0 +// enables it. Write stride/size default to the read // knobs. Returns FEEDSIM_SWEEP_WN (cached after first call, which allocates the // write buffer). int sweepWritesPerCall();