comments are sometimes placed at the end of lines, making formatting non-idempotent

[froydnj]

I'm seeing this behavior on Stripe's codebase, but I haven't managed to reduce a testcase yet. The testcase looks something like:

foo(
  read_from_cache_func: -> (limestone_result, local_cache) {
    cached_connections = applications
      .map do |application|
        local_cache.authorized_connection_cache.get_thing_by_the_things(
          account_granting: account,
          application: application.token
        )
      end
      .compact
    # for now assume cache miss if any connection application lookup returns nil
    return cached_connections.size == applications.size
  },
  command_name: "fake_command_name_with_bees"
)

and rubyfmt will take the comment and place it at the end of the return line...but if you format it again, it will correctly place it in the location it is above.

[fables-tales]

@froydnj the rubyfmt.run on this example looks correct to me:

https://rubyfmt.run/#Zm9vKAogIHJlYWRfZnJvbV9jYWNoZV9mdW5jOiAtPiAobGltZXN0b25lX3Jlc3VsdCwgbG9jYWxfY2FjaGUpIHsKICAgIGNhY2hlZF9jb25uZWN0aW9ucyA9IGFwcGxpY2F0aW9ucwogICAgICAubWFwIGRvIHxhcHBsaWNhdGlvbnwKICAgICAgICBsb2NhbF9jYWNoZS5hdXRob3JpemVkX2Nvbm5lY3Rpb25fY2FjaGUuZ2V0X3RoaW5nX2J5X3RoZV90aGluZ3MoCiAgICAgICAgICBhY2NvdW50X2dyYW50aW5nOiBhY2NvdW50LAogICAgICAgICAgYXBwbGljYXRpb246IGFwcGxpY2F0aW9uLnRva2VuCiAgICAgICAgKQogICAgICBlbmQKICAgICAgLmNvbXBhY3QKICAgICMgZm9yIG5vdyBhc3N1bWUgY2FjaGUgbWlzcyBpZiBhbnkgY29ubmVjdGlvbiBhcHBsaWNhdGlvbiBsb29rdXAgcmV0dXJucyBuaWwKICAgIHJldHVybiBjYWNoZWRfY29ubmVjdGlvbnMuc2l6ZSA9PSBhcHBsaWNhdGlvbnMuc2l6ZQogIH0sCiAgY29tbWFuZF9uYW1lOiAiZmFrZV9jb21tYW5kX25hbWVfd2l0aF9iZWVzIgop

[froydnj]

@fables-tales Yes, I haven't managed to make a proper test case yet. But that is the approximate shape of the test case.