Skip to content

warnings #1

@psigelo

Description

@psigelo

Estimado,

  1. lo compilé con make, me arrojó muchos warnings como se puede observar de la salida por consola:
$ make

mkdir build
g++  -g -Wall -I include -c src/neat.cpp -o build/neat.o
g++  -g -Wall -I include -c src/network.cpp -o build/network.o
g++  -g -Wall -I include -c src/nnode.cpp -o build/nnode.o
g++  -g -Wall -I include -c src/link.cpp -o build/link.o
g++  -g -Wall -I include -c src/trait.cpp -o build/trait.o
g++  -g -Wall -I include -c src/gene.cpp -o build/gene.o
g++  -g -Wall -I include -c src/genome.cpp -o build/genome.o
src/genome.cpp: In constructor ‘NEAT::Genome::Genome(int, int, int, int, int, bool, double)’:
src/genome.cpp:232:6: warning: variable ‘ccount’ set but not used [-Wunused-but-set-variable]
  int ccount;
      ^
src/genome.cpp: In member function ‘bool NEAT::Genome::mutate_add_node(std::vector<NEAT::Innovation*>&, int&, double&)’:
src/genome.cpp:1495:43: warning: comparison between ‘enum NEAT::Innovation::innovtype’ and ‘enum NEAT::innovtype’ [-Wenum-compare]
   else if (((*theinnov)->innovation_type==NEWNODE)&&
                                           ^
src/genome.cpp: In member function ‘bool NEAT::Genome::mutate_add_link(std::vector<NEAT::Innovation*>&, double&, int)’:
src/genome.cpp:1639:27: warning: comparison between ‘enum NEAT::nodetype’ and ‘enum NEAT::nodeplace’ [-Wenum-compare]
      if (((nodep1->type)==OUTPUT)||
                           ^
src/genome.cpp:1640:24: warning: comparison between ‘enum NEAT::nodetype’ and ‘enum NEAT::nodeplace’ [-Wenum-compare]
       ((nodep2->type)==OUTPUT))
                        ^
src/genome.cpp:1705:27: warning: comparison between ‘enum NEAT::nodetype’ and ‘enum NEAT::nodeplace’ [-Wenum-compare]
      if (((nodep1->type)==OUTPUT)||
                           ^
src/genome.cpp:1706:24: warning: comparison between ‘enum NEAT::nodetype’ and ‘enum NEAT::nodeplace’ [-Wenum-compare]
       ((nodep2->type)==OUTPUT))
                        ^
src/genome.cpp:1786:44: warning: comparison between ‘enum NEAT::Innovation::innovtype’ and ‘enum NEAT::innovtype’ [-Wenum-compare]
    else if (((*theinnov)->innovation_type==NEWLINK)&&
                                            ^
src/genome.cpp: In member function ‘void NEAT::Genome::mutate_add_sensor(std::vector<NEAT::Innovation*>&, double&)’:
src/genome.cpp:1844:29: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
  for (i = 0; i < nodes.size(); i++) {
                             ^
src/genome.cpp:1861:34: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   for (int j = 0; j < genes.size(); j++) {
                                  ^
src/genome.cpp:1869:41: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   if (outputConnections == outputs.size()) {
                                         ^
src/genome.cpp:1883:35: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
  for (int i = 0; i < outputs.size(); i++) {
                                   ^
src/genome.cpp:1887:30: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   for (j = 0; j < genes.size(); j++) {
                              ^
src/genome.cpp:1925:45: warning: comparison between ‘enum NEAT::Innovation::innovtype’ and ‘enum NEAT::innovtype’ [-Wenum-compare]
     else if (((*theinnov)->innovation_type==NEWLINK)&&
                                             ^
src/genome.cpp: In member function ‘void NEAT::Genome::add_gene(std::vector<NEAT::Gene*>&, NEAT::Gene*)’:
src/genome.cpp:1960:10: warning: unused variable ‘p1innov’ [-Wunused-variable]
   double p1innov;
          ^
src/genome.cpp: In member function ‘double NEAT::Genome::compatibility(NEAT::Genome*)’:
src/genome.cpp:2940:9: warning: variable ‘max_genome_size’ set but not used [-Wunused-but-set-variable]
  double max_genome_size; //Size of larger Genome
         ^
g++  -g -Wall -I include -c src/innovation.cpp -o build/innovation.o
g++  -g -Wall -I include -c src/organism.cpp -o build/organism.o
g++  -g -Wall -I include -c src/species.cpp -o build/species.o
src/species.cpp:119:20: warning: "/*" within comment [-Wcomment]
  //outFile<<endl<<"/* Species #"<<id<<" : (Size "<<organisms.size()<<") (AF "<<ave_fitness<<") (Age "<<age<<")  *///"<<endl<<endl;
 ^
src/species.cpp: In member function ‘bool NEAT::Species::print_to_file(std::ostream&)’:
src/species.cpp:189:111: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘std::vector<NEAT::Organism*>::size_type {aka long unsigned int}’ [-Wformat=]
  sprintf(tempbuf,"/* Species #%d : (Size %d) (AF %f) (Age %d)  */\n\n", id, organisms.size(), average_est, age);
                                                                                                               ^
src/species.cpp: In member function ‘bool NEAT::Species::reproduce(int, NEAT::Population*, std::vector<NEAT::Species*>&)’:
src/species.cpp:432:6: warning: unused variable ‘pause’ [-Wunused-variable]
  int pause;
      ^
src/species.cpp:451:9: warning: unused variable ‘total_fitness’ [-Wunused-variable]
  double total_fitness=0.0;
         ^
src/species.cpp:452:9: warning: unused variable ‘marble’ [-Wunused-variable]
  double marble;  //The marble will have a number between 0 and total_fitness
         ^
src/species.cpp:453:9: warning: unused variable ‘spin’ [-Wunused-variable]
  double spin;  //0Fitness total while the wheel is spinning
         ^
g++  -g -Wall -I include -c src/population.cpp -o build/population.o
src/population.cpp: In constructor ‘NEAT::Population::Population(std::vector<NEAT::Genome*>, float)’:
src/population.cpp:70:6: warning: unused variable ‘count’ [-Wunused-variable]
  int count;
      ^
src/population.cpp: In constructor ‘NEAT::Population::Population(const char*)’:
src/population.cpp:100:7: warning: unused variable ‘delimiters’ [-Wunused-variable]
  char delimiters[] = " \n";
       ^
src/population.cpp:112:6: warning: variable ‘curwordnum’ set but not used [-Wunused-but-set-variable]
  int curwordnum = 0;
      ^
src/population.cpp: In member function ‘bool NEAT::Population::epoch(int)’:
src/population.cpp:738:10: warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wparentheses]
       if (randfloat()>0.1)
          ^
src/population.cpp:431:6: warning: unused variable ‘pause’ [-Wunused-variable]
  int pause;
      ^
src/population.cpp:449:6: warning: unused variable ‘num_species_target’ [-Wunused-variable]
  int num_species_target=4;
      ^
src/population.cpp:451:9: warning: unused variable ‘compat_mod’ [-Wunused-variable]
  double compat_mod=0.3;  //Modify compat thresh to control speciation
         ^
g++  -g -Wall -I include -c src/experiments.cpp -o build/experiments.o
src/experiments.cpp: In function ‘bool xor_evaluate(NEAT::Organism*)’:
src/experiments.cpp:140:10: warning: variable ‘this_out’ set but not used [-Wunused-but-set-variable]
   double this_out; //The current output
          ^
src/experiments.cpp:145:7: warning: variable ‘numnodes’ set but not used [-Wunused-but-set-variable]
   int numnodes;  /* Used to figure out how many nodes
       ^
src/experiments.cpp: In function ‘NEAT::Population* pole2_test(int, int)’:
src/experiments.cpp:633:30: warning: deprecated conversion from string constant to ‘char*’ [-Wwrite-strings]
     char *non_markov_starter="pole2startgenes2";
                              ^
src/experiments.cpp:634:26: warning: deprecated conversion from string constant to ‘char*’ [-Wwrite-strings]
     char *markov_starter="pole2startgenes1";
                          ^
src/experiments.cpp:717:14: warning: deleting object of polymorphic class type ‘CartPole’ which has non-virtual destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor]
       delete thecart;
              ^
g++  -g -Wall -I include -c src/neatmain.cpp -o build/neatmain.o
src/neatmain.cpp: In function ‘int main(int, char**)’:
src/neatmain.cpp:51:7: warning: unused variable ‘pause’ [-Wunused-variable]
   int pause;
       ^
g++  -g -Wall -I include build/neat.o build/network.o build/nnode.o build/link.o build/trait.o build/gene.o build/genome.o build/innovation.o build/organism.o build/species.o build/population.o build/experiments.o build/neatmain.o -o neat ## removed -c 

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions