Skip to content
This repository was archived by the owner on Dec 18, 2019. It is now read-only.
This repository was archived by the owner on Dec 18, 2019. It is now read-only.

graphite color support missing support for longer colors (results in no colors set) #15

@keen99

Description

@keen99

https://github.com/etsy/dashboard/blob/master/htdocs/phplib/GraphFactory.php#L410

here we're restricting our match only to color codes that are 6 characters long - but shorter and longer colors are valid for graphite.

https://github.com/etsy/dashboard/blob/master/htdocs/phplib/GraphFactory.php#L413

then, if we failed that condition, we just leave the color unset, resulting in:
&colorList=

in our graph uri...

would be easy enough to accept a shorter/longer code, trigger an error/warning when an unacceptable code is sent, and/or select a random color from the list instead....

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions