Skip to content

Commit 56f23cf

Browse files
etrclaude
andcommitted
TASK-081: check off action items and persist 29 unworked review findings
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 parent 86f2889 commit 56f23cf

2 files changed

Lines changed: 131 additions & 6 deletions

File tree

specs/tasks/M7-v2-cleanup/TASK-081.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@ Several unit suites have near-zero effective coverage on the CI lanes that matte
1616
Make sure every suite actually exercises code on the build configuration where the feature is *available* (the inverse of what each gate currently does).
1717

1818
**Action Items:**
19-
- [ ] `webserver_ws_unavailable_test.cpp`: invert the guard so the suite exercises the `HAVE_WEBSOCKET`-off path (or rename + add a paired `webserver_ws_available_test.cpp` for the on-path). Goal: each build flag has a unit suite that runs.
20-
- [ ] `webserver_dauth_unavailable_test.cpp`: same pattern.
21-
- [ ] `header_hygiene_test.cpp`: investigate why the pthread leak detector was disabled on both stdlibs. Either fix the detector so it works (preferred — this is the entire purpose of the test) or delete the test with a documented `RELEASE_NOTES.md` entry. Coordinated with TASK-007.
22-
- [ ] `http_request_operator_stream_test.cpp`: split the credential-redaction tests into two — the `HAVE_BAUTH`-on variant pins redaction-when-set; the `HAVE_BAUTH`-off variant pins that the auth-related fields are absent from the stream.
23-
- [ ] `body_test.cpp` / `http_response_factories_test.cpp` / `iovec_entry_test.cpp`: write a Windows-shaped variant of the pipe/iovec tests using Windows native equivalents (CreateFileMapping for the fd source, etc.) or document the gap in `test/PORTABILITY.md`.
24-
- [ ] `webserver_register_ws_smartptr_test.cpp`: same pattern as `webserver_ws_unavailable_test`.
19+
- [x] `webserver_ws_unavailable_test.cpp`: invert the guard so the suite exercises the `HAVE_WEBSOCKET`-off path (or rename + add a paired `webserver_ws_available_test.cpp` for the on-path). Goal: each build flag has a unit suite that runs.
20+
- [x] `webserver_dauth_unavailable_test.cpp`: same pattern.
21+
- [x] `header_hygiene_test.cpp`: investigate why the pthread leak detector was disabled on both stdlibs. Either fix the detector so it works (preferred — this is the entire purpose of the test) or delete the test with a documented `RELEASE_NOTES.md` entry. Coordinated with TASK-007.
22+
- [x] `http_request_operator_stream_test.cpp`: split the credential-redaction tests into two — the `HAVE_BAUTH`-on variant pins redaction-when-set; the `HAVE_BAUTH`-off variant pins that the auth-related fields are absent from the stream.
23+
- [x] `body_test.cpp` / `http_response_factories_test.cpp` / `iovec_entry_test.cpp`: write a Windows-shaped variant of the pipe/iovec tests using Windows native equivalents (CreateFileMapping for the fd source, etc.) or document the gap in `test/PORTABILITY.md`.
24+
- [x] `webserver_register_ws_smartptr_test.cpp`: same pattern as `webserver_ws_unavailable_test`.
2525

2626
**Dependencies:**
2727
- Blocked by: None

0 commit comments

Comments
 (0)