From 1e22d08ab02bd3378ee05164ec94ffd153146daa Mon Sep 17 00:00:00 2001 From: Sergio Bobillier Date: Wed, 18 Mar 2026 14:15:49 +0100 Subject: [PATCH 1/3] Update Ruby version for workflows Updates the version of ruby because the workflows were failing. --- .github/workflows/release.yml | 2 +- .github/workflows/ruby-linters.yml | 2 +- .github/workflows/ruby-tests.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index e34eb78..b40ea04 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -20,7 +20,7 @@ jobs: - name: Set up Ruby 3.2 uses: ruby/setup-ruby@v1 with: - ruby-version: '3.2' + ruby-version: '3.4' - name: Build run: | bundler install diff --git a/.github/workflows/ruby-linters.yml b/.github/workflows/ruby-linters.yml index 361b685..82a8e37 100644 --- a/.github/workflows/ruby-linters.yml +++ b/.github/workflows/ruby-linters.yml @@ -22,7 +22,7 @@ jobs: - name: Set up Ruby uses: ruby/setup-ruby@v1 with: - ruby-version: '3.2' + ruby-version: '3.4' - name: Install Gems run: | bundler install diff --git a/.github/workflows/ruby-tests.yml b/.github/workflows/ruby-tests.yml index 65af7d5..93c0eee 100644 --- a/.github/workflows/ruby-tests.yml +++ b/.github/workflows/ruby-tests.yml @@ -22,7 +22,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - ruby-version: ['3.2'] + ruby-version: ['3.4'] steps: - uses: actions/checkout@v4 From 71cb037744035c596fde97f3efb5fed63eeb6872 Mon Sep 17 00:00:00 2001 From: Sergio Bobillier Date: Wed, 18 Mar 2026 14:33:04 +0100 Subject: [PATCH 2/3] Undo changes for the tests --- .github/workflows/ruby-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ruby-tests.yml b/.github/workflows/ruby-tests.yml index 93c0eee..65af7d5 100644 --- a/.github/workflows/ruby-tests.yml +++ b/.github/workflows/ruby-tests.yml @@ -22,7 +22,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - ruby-version: ['3.4'] + ruby-version: ['3.2'] steps: - uses: actions/checkout@v4 From 93de5c0d1950de4990a7e4d5a881b23e20e8387e Mon Sep 17 00:00:00 2001 From: Sergio Bobillier Date: Wed, 18 Mar 2026 14:40:22 +0100 Subject: [PATCH 3/3] Changes to test the verifier --- lib/jay_api/elasticsearch/async.rb | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/lib/jay_api/elasticsearch/async.rb b/lib/jay_api/elasticsearch/async.rb index 07ae3a9..3ece3ef 100644 --- a/lib/jay_api/elasticsearch/async.rb +++ b/lib/jay_api/elasticsearch/async.rb @@ -40,7 +40,7 @@ def initialize(index) # failures def delete_by_query(query, slices: 5) Concurrent::Promise.execute do - async_response = index.delete_by_query(query, slices: slices, wait_for_completion: false) + async_response = index.delete_by_query(query, slices:, wait_for_completion: false) result = tasks.by_id(async_response[:task]) validate_result(result) result @@ -49,6 +49,14 @@ def delete_by_query(query, slices: 5) private + + + + + + + + # @param [Hash] result The operation result to be validated # @raise [Errors::QueryExecutionError] If executing the query results in # errors @@ -56,7 +64,6 @@ def delete_by_query(query, slices: 5) # failures def validate_result(result) raise Errors::QueryExecutionError, "Errors on index '#{index_name}':\n #{result[:error]}" if result[:error] - failures = result&.dig(:response, :failures) return if failures.nil? || failures.empty?