Cannot read property 'name' of undefined when trying to set queryParams in beforeModel

[ohcibi]

I'm getting the error TypeError: Cannot read property 'name' of undefined when trying to this.transitionTo({ queryParams: { somParam: 'someValue' } }) in this very line:

ember.js/packages/@ember/-internals/routing/lib/system/router.ts

Line 1083 in bef8602

let leafRouteName = routeInfos[handlerInfoLength - 1].name;

I debugged it and it appears that routeInfos is an empty array and therefore that line must throw naturally. As I am unable to reproduce it in a twiddle and have no clue how to debug this further, I'd like to know what an empty routeInfos array actually means here and if this is an error after all or rather a bug? When looking at my app, it works as expected, i.e. the query parameter does get set and the URL in the browser is updated accordingly. So this is not an issue about the query parameter not being set.

For the matter of this issue, I'd say a check if that array is empty and a better error message should be added. I can't PR this as I don't understand the internals here, otherwise I would.

[pixelhandler]

@ohcibi well if creating an example reproduction of the issue in a twiddle is not working out, perhaps create an example project and share the link to clone the repository.

[ohcibi]

I was able to do that in the meantime... I pushed it to https://github.com/ohcibi/erstifahrt and pushed the wip/activation-flash-message branch only but in case I messed up, check out that branch explicitly. Then simply npm install && npm start and open localhost:4200/anmeldung/1?activated=1. The app should redirect you to the same route without the query param but said error will still be thrown.

[dodeja]

Any update on this?

[ohcibi]

@dodeja do you have another example that differs from mine? If yes, please provide it as this issue seems to be more complicated than expected.

[ohcibi]

@pixelhandler have you been able looking into the example yet? Is it a valid example or is anything else needed?

[betocantu93]

I stumbled with this too, I'm using ember-parachute

Facts I know:
This happens only when I immediately try to transitionTo after ember-simple-auth successfully login

login(credentials).then( () => 
  this.router.transitionTo('route.name', { queryParams: { userId: 5 } ) 
)

But I if I wrap the transitionTo with a

login(credentials).then( () => 
   setTimeout( () => //maybe a { next } from @ember/runloop might do it.
      this.router.transitionTo('route.name', { queryParams: { userId: 5 } ), 
   1000 )
)

It works... I know maybe the ember-parachute or ember-simple-auth has nothing to do, but I mean, maybe in that context it helps to debug, it's like a race condition

[betocantu93]

It seems, ember-simple-auth UnauthenticatedRouteMixin is doing a transition for me as expected - if user is authenticated transitionTo('index') without any queryParams -

But at the same time I'm also triggering a transition to the same route but with queryParams (my app is served as an iframe, so external consumers send actions down to my ember app via postMessage API, and I can't control when they do it), and that's when I get this error.

If I instead try transitionTo another route, (not the same one) it works, without issue, as expected, it's like I need to wait to the router/transition to settle down, before I can attempt a new transition, to the same route.

I truly don't know about internals here, but it comes to my mind something like

this.router.hasSettled().then(() => this.router.transitionTo(...))

Or maybe its something that can be handled internally?

[jordpo]

I ran into this issue as well. The solution I came up with is to do a full transition.abort then retry inside a run.next block.

      next(this, function() {
        transition.abort();
        this.transitionTo(transition.to.name, {queryParams: validParams});
      });

[jordpo]

You probably don't want to do what I posted since it will trigger the transition.to's model hooks before retrying. I can confirm that this is only an issue when trying to transitionTo the same route but with different query params. It does look like it is supported per the docs:

https://guides.emberjs.com/release/routing/query-params/#toc_transitionto

// if you want to transition the query parameters without changing the route
this.transitionTo({ queryParams: { direction: 'asc' }});

Is exactly what I am trying to do. I'm on 3.7.x for ember.

[jordpo]

I can only replicate this actually when running tests. Calling visit('/') before visiting the route that has the query param transition does seem to fix it.

[Turbo87]

@rwjblue any idea about this? I can repro this on one of my OSS apps too if someone needs it.

also, is this a duplicate of #14875?

[rwjblue]

I can only replicate this actually when running tests. Calling visit('/') before visiting the route that has the query param transition does seem to fix it.

So this error only occurs when doing a query param only transition during the initial visit?