From 29280a1ed3836c5e3119cea6cc967854e797b054 Mon Sep 17 00:00:00 2001 From: Leonhard Date: Mon, 10 Aug 2026 19:03:24 +0200 Subject: [PATCH 1/2] Add a workflow that checks for missing and invalid files in POTFILES --- .github/workflows/check-potfiles.sh | 26 ++++++++++++++++++++++++++ .github/workflows/main.yml | 11 +++++++++++ 2 files changed, 37 insertions(+) create mode 100644 .github/workflows/check-potfiles.sh diff --git a/.github/workflows/check-potfiles.sh b/.github/workflows/check-potfiles.sh new file mode 100644 index 000000000..9ad1d4725 --- /dev/null +++ b/.github/workflows/check-potfiles.sh @@ -0,0 +1,26 @@ +#!/usr/bin/env bash + +missing=0 +invalid=0 + +git ls-files | grep -E '\.(vala|desktop.in|metainfo.xml.in)$' | while read -r file; do + if grep -q -E '\b((_|C_|N_)\(|ngettext \()' "$file"; then + if ! grep -q "^$file$" po/POTFILES; then + echo "Missing from POTFILES: $file" + missing=1 + fi + fi +done + +while IFS= read -r file; do + if [[ -z "$file" ]]; then + continue + fi + + if [[ ! -f "$file" ]]; then + echo "Found in POTFILES but missing: $file" + invalid=1 + fi +done < po/POTFILES + +exit $((missing || invalid)) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 11a89f6f8..b3475d66f 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -103,3 +103,14 @@ jobs: io.elementary.vala-lint -d plugins io.elementary.vala-lint -d src io.elementary.vala-lint -d tests + + potfiles: + runs-on: ubuntu-latest + + steps: + - name: Repository checkout + uses: actions/checkout@v6 + + - name: Check POTFILES + run: bash .github/workflows/check-potfiles.sh + From 588c267f2eefa7e3c136f3836534ee4b613953ad Mon Sep 17 00:00:00 2001 From: Leonhard Date: Mon, 10 Aug 2026 19:21:07 +0200 Subject: [PATCH 2/2] Fix POTFILES --- po/POTFILES | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/po/POTFILES b/po/POTFILES index 5fe1be65c..349c497bb 100644 --- a/po/POTFILES +++ b/po/POTFILES @@ -3,6 +3,7 @@ daemon/IBus/CandidateArea.vala daemon/IBus/CandidateBox.vala daemon/IBus/IBusCandidateWindow.vala daemon/IBus/IBusService.vala +daemon/OSK/Window/Keyboard/KeyButton.vala daemon/DBus.vala daemon/DisplayConfig.vala daemon/Main.vala @@ -65,6 +66,7 @@ lib/Constants.vala lib/DragDropAction.vala lib/Plugin.vala lib/SessionSettings.vala +lib/TransitionBuilder.vala lib/Utils.vala lib/WindowManager.vala @@ -151,6 +153,5 @@ src/InternalUtils.vala src/Main.vala src/PantheonShell.vala src/SuperScrollAction.vala -src/TransitionBuilder.vala src/WindowListModel.vala src/WindowManager.vala