Skip to content

fix(gui): null version #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
binarybaron merged 1 commit into from
Jun 5, 2026
Merged

fix(gui): null version #1068

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src-gui/src/utils/multiAddrUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,25 +17,25 @@ export function isMakerOnCorrectNetwork(
}

/** Check whether a maker version is old and might not support newer features. */
export function isMakerVersionOld(version: string | undefined): boolean {
if (version === undefined) return false;
export function isMakerVersionOld(version: string | null | undefined): boolean {
if (version == null) return false;
// This checks if the version is less than the minimum version
// we use .compare(...) instead of .satisfies(...) because satisfies(...)
// does not work with pre-release versions
return semver.compare(version, VERSION_FLOOR_SOFT) === -1;
}

/** Check whether a maker version is too old and is known to be completely incompatile. */
export function isMakerVersionTooOld(version: string | undefined): boolean {
if (version === undefined) return false;
export function isMakerVersionTooOld(version: string | null | undefined): boolean {
if (version == null) return false;
return semver.compare(version, VERSION_FLOOR_HARD) === -1;
}

/** Check whether a maker is running at or above the GUI's bundled version. */
export function isMakerVersionLatest(
version: string | undefined,
guiVersion: string | undefined,
version: string | null | undefined,
guiVersion: string | null | undefined,
): boolean {
if (version === undefined || guiVersion === undefined) return false;
if (version == null || guiVersion == null) return false;
return semver.compare(version, guiVersion) >= 0;
}
Loading