fix(gui): null version#1068
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A maker with no advertised version arrives from the backend as JSON null (Rust Option serializing None), but typeshare types the field as version?: string, hiding the null at the type level. The guard functions in multiAddrUtils.ts only bailed on undefined, so a null version slipped through to semver.compare(null, ...), which throws "Invalid version. Must be a string. Got type object" (typeof null === "object"). Because this happens during render of the offer list, the exception propagated up and crashed the entire swap page into the error boundary.
This widens the three guard signatures to accept null and switches their checks to nullish so both null and undefined are rejected before reaching semver, which is the correct answer since a maker with no version has nothing to compare against.