From dc5a7a962e277d982109c80867e31e5158bfb16f Mon Sep 17 00:00:00 2001 From: enricopolanski Date: Tue, 2 Jun 2026 16:59:21 +0200 Subject: [PATCH] fix: TS diagnostic in events middleware and TextField prop binding order - events middleware: suppress effect/returnEffectInGen so makeEvents returns the SSE Effect (callers yield* it). Removing the diagnostic fixes the TS2345 at router.ts where handleEvents.pipe(Effect.tapCause) required an Effect, not a bare HttpServerResponse. - TextField.vue: bind v-bind="$props" before :type so the computed number/text type is not overridden by an incoming $props.type. --- api/src/lib/middleware/events.ts | 2 ++ frontend/components/TextField.vue | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/api/src/lib/middleware/events.ts b/api/src/lib/middleware/events.ts index 4efdb292..5c1d7e89 100644 --- a/api/src/lib/middleware/events.ts +++ b/api/src/lib/middleware/events.ts @@ -3,7 +3,9 @@ import { Events } from "#services/Events" import { makeSSE } from "@effect-app/infra/middlewares" import * as Effect from "effect-app/Effect" +// @effect-diagnostics effect/returnEffectInGen:off export const makeEvents = Effect.gen(function*() { const events = yield* Events + return makeSSE(ClientEvents)(events.stream) }) diff --git a/frontend/components/TextField.vue b/frontend/components/TextField.vue index 115811aa..e26f0118 100644 --- a/frontend/components/TextField.vue +++ b/frontend/components/TextField.vue @@ -1,7 +1,7 @@