Cannot clone earthkit-data repository on Windows

[burggraaff]

What happened?

I'm trying to clone earthkit-data on a Windows machine but it won't let me checkout because of an invalid path. I think the issue is that some of the filenames in https://github.com/ecmwf/earthkit-data/tree/develop/tests/data/pattern/1 (added in #659) contain : which Linux is fine with but Windows doesn't accept.

It's fine of course if Windows is not supported in this way, but then please add a warning to the README or elsewhere.

What are the steps to reproduce the bug?

On a Windows machine:

git clone git@github.com:ecmwf/earthkit-data.git

Version

0.16.1

Platform (OS and architecture)

Windows 11 Enterprise, Version 24H2, OS Build 26100.4652

Relevant log output

Cloning into 'earthkit-data'...
remote: Enumerating objects: 10251, done.
remote: Counting objects: 100% (2897/2897), done.
remote: Compressing objects: 100% (1292/1292), done.
remote: Total 10251 (delta 2258), reused 1644 (delta 1561), pack-reused 7354 (from 5)
Receiving objects: 100% (10251/10251), 29.50 MiB | 11.47 MiB/s, done.
Resolving deltas: 100% (6656/6656), done.
error: invalid path 'tests/data/pattern/1/r_2020-09-22T12:00:00_0.grib'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

Accompanying data

No response

Organisation

No response

[sandorkertesz]

@burggraaff, thank you for reporting this issue. The code will be updated so that the repo cloning could work on Windows.

[sandorkertesz]

@burggraaff, if you try now the cloning should work. Please let me know if there are still issues with it.

[burggraaff]

@sandorkertesz It works now, thank you very much :)