From e748d53a9613fc4aeb54a182d46eafafbbdde6ac Mon Sep 17 00:00:00 2001 From: Andreas Zwinkau Date: Mon, 29 Jun 2026 12:13:02 +0200 Subject: [PATCH 1/7] fix: satisfied valid_from/until already --- docs/internals/requirements/requirements.rst | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/internals/requirements/requirements.rst b/docs/internals/requirements/requirements.rst index 6d1e79bed..c85a33394 100644 --- a/docs/internals/requirements/requirements.rst +++ b/docs/internals/requirements/requirements.rst @@ -503,7 +503,10 @@ Versioning :implemented: YES :version: 2 :parent_covered: YES - :satisfies: gd_req__req_validity[version==1] + :satisfies: + gd_req__req_validity[version==1], + gd_req__req_attr_valid_from[version==1], + gd_req__req_attr_valid_until[version==1], :status: valid Docs-as-Code shall enforce that the ``valid_from`` and ``valid_until`` attributes of stakeholder and feature requirements are correct. From 29f288f34054b23656ffac3034e04d259c6b476c Mon Sep 17 00:00:00 2001 From: Andreas Zwinkau Date: Mon, 29 Jun 2026 13:04:42 +0200 Subject: [PATCH 2/7] chore: add tool_req__arch_linkage_safety --- docs/internals/requirements/requirements.rst | 28 +++++++++++++++++++ src/extensions/score_metamodel/metamodel.yaml | 6 ++++ 2 files changed, 34 insertions(+) diff --git a/docs/internals/requirements/requirements.rst b/docs/internals/requirements/requirements.rst index c85a33394..86aadb430 100644 --- a/docs/internals/requirements/requirements.rst +++ b/docs/internals/requirements/requirements.rst @@ -791,6 +791,34 @@ Architecture Attributes "belongs_to", "corresponding architecture element same level" "includes", "corresponding architecture element lower level" +The following requirement maybe be overlapping with other tool requirements, +but for ease of traceability this is a separate one. + +.. tool_req:: Correlations of the architectural building blocks + :id: tool_req__arch_linkage_safety + :implemented: PARTIAL + :version: 1 + :satisfies: gd_req__arch_linkage_safety[version==1] + :parent_covered: YES + + .. csv-table:: + :header: "Link source", "Relation", "Link Target", "Mandatory", "Implemented" + + feat, consist_of, comp, yes, no + feat, includes, logic_arc_int, yes, only optional + mod, includes, comp, yes, yes + real_arc_int_op, included by, real_arc_int, yes, yes + logic_arc_int, includes, logic_arc_int_op, no, yes + real_arc_int_op, implements, logic_arc_int_op, no, yes + comp, implements, logic_arc_int, no, yes + comp, uses, logic_arc_int, no, yes + comp, consists_of, comp, no, yes + + .. warning:: + + Implementation and this requirement uses ``consists_of`` + while :need:`gd_req__arch_linkage_safety` uses ``consist_of`` + without the "s". 💻 Detailed Design & Code ########################## diff --git a/src/extensions/score_metamodel/metamodel.yaml b/src/extensions/score_metamodel/metamodel.yaml index e734cb870..eeb415f5a 100644 --- a/src/extensions/score_metamodel/metamodel.yaml +++ b/src/extensions/score_metamodel/metamodel.yaml @@ -415,6 +415,7 @@ needs_types: # req-Id: tool_req__docs_common_attr_status status: ^(valid|invalid)$ optional_links: + # req-Id: tool_req__arch_linkage_safety includes: logic_arc_int, logic_arc_int_op uses: logic_arc_int, logic_arc_int_op provides: logic_arc_int, logic_arc_int_op # preparation for linking change according to DR-005 @@ -485,6 +486,7 @@ needs_types: # req-Id: tool_req__docs_common_attr_status status: ^(valid|invalid)$ optional_links: + # req-Id: tool_req__arch_linkage_safety includes: logic_arc_int_op fulfils: feat_req tags: @@ -526,6 +528,7 @@ needs_types: # req-Id: tool_req__docs_common_attr_status status: ^(valid|invalid)$ mandatory_links: + # req-Id: tool_req__arch_linkage_safety includes: comp tags: - architecture_element @@ -572,6 +575,7 @@ needs_types: mandatory_links: belongs_to: feat # preparation for linking change according to DR-005 optional_links: + # req-Id: tool_req__arch_linkage_safety implements: logic_arc_int, real_arc_int_op uses: logic_arc_int, real_arc_int_op consists_of: comp @@ -660,8 +664,10 @@ needs_types: # req-Id: tool_req__docs_common_attr_status status: ^(valid|invalid)$ mandatory_links: + # req-Id: tool_req__arch_linkage_safety included_by: real_arc_int optional_links: + # req-Id: tool_req__arch_linkage_safety implements: logic_arc_int_op tags: - architecture_element From 16f2e53a26926bf9b1037af224af6571b9468549 Mon Sep 17 00:00:00 2001 From: RolandJentschETAS <135332348+RolandJentschETAS@users.noreply.github.com> Date: Mon, 29 Jun 2026 14:00:21 +0200 Subject: [PATCH 3/7] Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: RolandJentschETAS <135332348+RolandJentschETAS@users.noreply.github.com> --- docs/internals/requirements/requirements.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/internals/requirements/requirements.rst b/docs/internals/requirements/requirements.rst index 86aadb430..e211eee89 100644 --- a/docs/internals/requirements/requirements.rst +++ b/docs/internals/requirements/requirements.rst @@ -791,7 +791,7 @@ Architecture Attributes "belongs_to", "corresponding architecture element same level" "includes", "corresponding architecture element lower level" -The following requirement maybe be overlapping with other tool requirements, +The following requirement may be overlapping with other tool requirements, but for ease of traceability this is a separate one. .. tool_req:: Correlations of the architectural building blocks From 4290ff9a791ee534a751ea24cfb028a026470eb0 Mon Sep 17 00:00:00 2001 From: RolandJentschETAS <135332348+RolandJentschETAS@users.noreply.github.com> Date: Mon, 29 Jun 2026 14:07:15 +0200 Subject: [PATCH 4/7] Fix typo in requirements.rst from 'included by' to 'included_by' Signed-off-by: RolandJentschETAS <135332348+RolandJentschETAS@users.noreply.github.com> --- docs/internals/requirements/requirements.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/internals/requirements/requirements.rst b/docs/internals/requirements/requirements.rst index e211eee89..48fab5b4c 100644 --- a/docs/internals/requirements/requirements.rst +++ b/docs/internals/requirements/requirements.rst @@ -807,7 +807,7 @@ but for ease of traceability this is a separate one. feat, consist_of, comp, yes, no feat, includes, logic_arc_int, yes, only optional mod, includes, comp, yes, yes - real_arc_int_op, included by, real_arc_int, yes, yes + real_arc_int_op, included_by, real_arc_int, yes, yes logic_arc_int, includes, logic_arc_int_op, no, yes real_arc_int_op, implements, logic_arc_int_op, no, yes comp, implements, logic_arc_int, no, yes From a581974e677e861d1d0cf33f6c7c359025a5ae25 Mon Sep 17 00:00:00 2001 From: RolandJentschETAS <135332348+RolandJentschETAS@users.noreply.github.com> Date: Mon, 29 Jun 2026 14:12:19 +0200 Subject: [PATCH 5/7] Fix formatting of requirement links in documentation Signed-off-by: RolandJentschETAS <135332348+RolandJentschETAS@users.noreply.github.com> --- docs/internals/requirements/requirements.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/internals/requirements/requirements.rst b/docs/internals/requirements/requirements.rst index 48fab5b4c..881bca699 100644 --- a/docs/internals/requirements/requirements.rst +++ b/docs/internals/requirements/requirements.rst @@ -908,9 +908,9 @@ Testing Docs-as-Code shall ensure that test cases link to requirements on the correct level: - - If Partially/FullyVerifies are set in Feature Integration Test these shall link to Feature Requirements - - If Partially/FullyVerifies are set in Component Integration Test these shall link to Component Requirements - - If Partially/FullyVerifies are set in Unit Test these shall link to Component Requirements + - If Partially/FullyVerifies are set in Feature Integration Test these shall link to Feature Requirements + - If Partially/FullyVerifies are set in Component Integration Test these shall link to Component Requirements + - If Partially/FullyVerifies are set in Unit Test these shall link to Component Requirements .. tool_req:: Provide Metrics for linked requirements From a02099ff3275fcec0a907c72202fde7a7c6001ca Mon Sep 17 00:00:00 2001 From: RolandJentschETAS <135332348+RolandJentschETAS@users.noreply.github.com> Date: Mon, 29 Jun 2026 14:22:20 +0200 Subject: [PATCH 6/7] Fix formatting for Docs-As-Code need types section Signed-off-by: RolandJentschETAS <135332348+RolandJentschETAS@users.noreply.github.com> --- docs/internals/requirements/requirements.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/internals/requirements/requirements.rst b/docs/internals/requirements/requirements.rst index 881bca699..77e4fa416 100644 --- a/docs/internals/requirements/requirements.rst +++ b/docs/internals/requirements/requirements.rst @@ -1065,7 +1065,7 @@ Testing gd_req__saf_attr_uid, :parent_covered: YES - Docs-As-Code shall support the following need types: + Docs-As-Code shall support the following need types: * Feature FMEA (Failure Modes and Effect Analysis) -> ``feat_saf_fmea`` * Component FMEA (Failure Modes and Effect Analysis) -> ``comp_saf_fmea`` From e4ac0aa7440125d9552747eeb4e7798e790738ce Mon Sep 17 00:00:00 2001 From: Andreas Zwinkau Date: Tue, 30 Jun 2026 11:44:38 +0200 Subject: [PATCH 7/7] fix: consistently consists_of It was only a typo in a single diagram in process. See https://github.com/eclipse-score/process_description/pull/728 --- docs/internals/requirements/requirements.rst | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/docs/internals/requirements/requirements.rst b/docs/internals/requirements/requirements.rst index 77e4fa416..003ddf0d6 100644 --- a/docs/internals/requirements/requirements.rst +++ b/docs/internals/requirements/requirements.rst @@ -804,7 +804,7 @@ but for ease of traceability this is a separate one. .. csv-table:: :header: "Link source", "Relation", "Link Target", "Mandatory", "Implemented" - feat, consist_of, comp, yes, no + feat, consists_of, comp, yes, no feat, includes, logic_arc_int, yes, only optional mod, includes, comp, yes, yes real_arc_int_op, included_by, real_arc_int, yes, yes @@ -814,11 +814,6 @@ but for ease of traceability this is a separate one. comp, uses, logic_arc_int, no, yes comp, consists_of, comp, no, yes - .. warning:: - - Implementation and this requirement uses ``consists_of`` - while :need:`gd_req__arch_linkage_safety` uses ``consist_of`` - without the "s". 💻 Detailed Design & Code ##########################