PrepareTransition does not reinit the lock states

[mPorhel]

Issue detected while moving Team for Capella from CDO 4.7 to 4.22 for Team for Capella 7.0 (corrected in a private fork)

Scenario still to be refined from our unit tests.

[estepper]

Issue detected

What is that issue?

[mPorhel]

The lock state is not re-initialized.

[estepper]

Sorry, I don't get this. From your commit mPorhel@693f8b6 I see that you really want to call lockState.remapID(object.cdoID()). But then your call is in the if(!reattaching) condition of the PrepareTransition. I think at this point a formerly TRANSIENT object can not have locks / lock states. I fear you'll have to explain to me in more detail why you want to have this. Perhaps you can demonstrate your problem with a test case like this:

/**
 * PrepareTransition does not reinit the lock states #72
 * <p>
 * See https://github.com/eclipse-cdo/cdo/issues/72
 *
 * @author Eike Stepper
 */
public class Issue_000072_Test extends AbstractLockingTest
{
  public void testExplicitLockingOfNewObject() throws Exception
  {
    CDOSession session = openSession();
    CDOTransaction transaction = session.openTransaction();
    transaction.options().setAutoReleaseLocksEnabled(false);

    Company company = getModel1Factory().createCompany();

    CDOResource resource = transaction.createResource(getResourcePath("test1"));
    resource.getContents().add(company);

    CDOObject cdoObject = CDOUtil.getCDOObject(company);
    cdoObject.cdoWriteLock().lock();

    CDOLockState lockState = cdoObject.cdoLockState();
    assertEquals(((InternalCDOTransaction)transaction).getLockOwner(), lockState.getWriteLockOwner());

    transaction.commit();

    assertWriteLock(true, company);
    System.out.println();
  }
}