Skip to content

[Bug/Critical] Improper handler processing #33

@alex3236

Description

@alex3236

The problem

  1. Easybot-MCDR ALWAYS registers its handler
  2. It tries to import all handlers and use the first one, however the code will always inherits ForgeHandler1 (why?)
  3. User could not turn off the handler.

In summary, a user using a non-Forge server or wants a custom handler will never be able to use your plugin.

Not all users needs a prefix handler which always inherits ForgeHandler!

The fix

Make it configurable please. For example:

{
    "enable_easybot_handler": false // Whether enable the handler, *should defaults to FALSE!*
    "parent_handler": "FabricHandler" // Loads and inherits mcdreforged.handler.impl.FabricHandler
}

Footnotes

  1. You can verify this by execute the code without launching MCDR.

Metadata

Metadata

Labels

bugSomething isn't working

Type

No fields configured for Bug.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions