From c11f3744d362a29f2092305337638f2d8e284e6c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oskar=20Kwas=CC=81niewski?= Date: Wed, 4 Nov 2026 19:32:11 +0100 Subject: [PATCH 1/2] feat(e2e)!: inputValue and isChecked throw on the wrong element, uncheck clicks ARIA radios Match Playwright: inputValue() on a node with no value and isChecked() on a node with no checked state throw ACTION_FAILED. uncheck() clicks a role=radio; only a native radio refuses. --- .changeset/locator-reads-wrong-element.md | 6 ++++ apps/testbed/tests/check.e2e.ts | 4 +-- apps/testbed/tests/locator-convenience.e2e.ts | 4 +-- docs/migrate/playwright.mdx | 15 +++++----- docs/reference/errors.mdx | 2 +- docs/reference/screen.mdx | 16 +++++++++-- packages/e2e/src/internal/roles.ts | 22 ++++++++++++++- packages/e2e/src/locator/screen.ts | 6 +++- packages/e2e/src/types.ts | 4 +-- .../tests/integration/scripted-reads.test.ts | 6 ++-- .../e2e/tests/unit/locator-basics.test.ts | 28 +++++++++++++++++-- packages/web/src/actions.ts | 21 +++++++++----- .../tests/integration/check-actions.test.ts | 16 +++++++++++ .../skills/e2e/references/writing-tests.md | 6 ++-- skills/e2e/references/writing-tests.md | 6 ++-- 15 files changed, 126 insertions(+), 36 deletions(-) create mode 100644 .changeset/locator-reads-wrong-element.md diff --git a/.changeset/locator-reads-wrong-element.md b/.changeset/locator-reads-wrong-element.md new file mode 100644 index 0000000000..0b5388a9ad --- /dev/null +++ b/.changeset/locator-reads-wrong-element.md @@ -0,0 +1,6 @@ +--- +'e2e': minor +'@e2e-dev/web': patch +--- + +**Breaking:** `inputValue()` on a node with no value, such as a heading or a button, and `isChecked()` on a node with no checked state throw `ACTION_FAILED`, as in Playwright, instead of returning `""` and `false`. A field with no value still reads `""`, and a checkable role with no state reported still reads `false`. `uncheck()` on an ARIA `role="radio"` now clicks it, as in Playwright; a native radio still refuses. diff --git a/apps/testbed/tests/check.e2e.ts b/apps/testbed/tests/check.e2e.ts index 38dca1edd1..88dbbd39b8 100644 --- a/apps/testbed/tests/check.e2e.ts +++ b/apps/testbed/tests/check.e2e.ts @@ -59,7 +59,7 @@ test.describe('page check', { requires: ['browser'], tags: ['playwright'] }, () expect(await browser.evaluate("() => window.checkbox.getAttribute('aria-checked')")).toBe('true'); }); - test('should uncheck radio by aria role', { fail: '`uncheck` refuses a `role=radio`, where Playwright clicks it and refuses only a native radio' }, async ({ browser }) => { + test('should uncheck radio by aria role', async ({ browser }) => { await browser.goto(content(`