Skip to content

Commit bcd354e

Browse files
fix: use fully qualified Graph type name to resolve namespace conflict
Use ArchUnitNet.Common.Extraction.Graph fully qualified name instead of alias to avoid conflict with ArchUnitNet.Graph namespace. Applies to all Graph constructor calls and return types in layer tests. Fixes: "'Graph' is a namespace but is used like a type" CI errors Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
1 parent 13a8db9 commit bcd354e

2 files changed

Lines changed: 16 additions & 18 deletions

File tree

‎tests/ArchUnitNet.Tests/Layers/LayerConstraintTests.cs‎

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,12 @@
55
using ArchUnitNet.Layers.FluentApi;
66
using ArchUnitNet.Layers.Projection;
77
using Xunit;
8-
using Graph = ArchUnitNet.Common.Extraction.Graph;
98

109
namespace ArchUnitNet.Tests.Layers;
1110

1211
public class LayerConstraintTests
1312
{
14-
private static Graph CreateSimpleLayeredGraph()
13+
private static ArchUnitNet.Common.Extraction.Graph CreateSimpleLayeredGraph()
1514
{
1615
// Create a 3-layer architecture: Presentation -> Business -> Data
1716
var edges = new List<Edge>
@@ -23,7 +22,7 @@ private static Graph CreateSimpleLayeredGraph()
2322
// Data layer (no external dependencies)
2423
new Edge("src/Data/Repository.cs", "System.Data.SqlClient", External: true, new[] { ImportKind.Using })
2524
};
26-
return new Graph(edges);
25+
return new ArchUnitNet.Common.Extraction.Graph(edges);
2726
}
2827

2928
[Fact]
@@ -84,7 +83,7 @@ public async Task LayerConstraint_MayOnlyDependOn_WithForbiddenLayer_FailsAsync(
8483
{
8584
new Edge("src/Presentation/Component.cs", "src/Data/Repository.cs", External: false, new[] { ImportKind.Using })
8685
};
87-
var graph = new Graph(edges);
86+
var graph = new ArchUnitNet.Common.Extraction.Graph(edges);
8887
var projector = new LayerProjector("src/{Layer}/**");
8988
var constraint = new LayerConstraint(graph, projector, "Presentation");
9089
constraint.SetAllowedLayers(new[] { "Business" });
@@ -109,7 +108,7 @@ public async Task LayerConstraint_MayNotDependOn_WithForbiddenLayer_FailsAsync()
109108
{
110109
new Edge("src/Presentation/Component.cs", "src/Data/Repository.cs", External: false, new[] { ImportKind.Using })
111110
};
112-
var graph = new Graph(edges);
111+
var graph = new ArchUnitNet.Common.Extraction.Graph(edges);
113112
var projector = new LayerProjector("src/{Layer}/**");
114113
var constraint = new LayerConstraint(graph, projector, "Presentation");
115114
constraint.SetForbiddenLayers(new[] { "Data" });
@@ -132,7 +131,7 @@ public async Task LayerConstraint_SealedLayer_WithExternalDependency_FailsAsync(
132131
{
133132
new Edge("src/Business/Service.cs", "src/Data/Repository.cs", External: false, new[] { ImportKind.Using })
134133
};
135-
var graph = new Graph(edges);
134+
var graph = new ArchUnitNet.Common.Extraction.Graph(edges);
136135
var projector = new LayerProjector("src/{Layer}/**");
137136
var constraint = new LayerConstraint(graph, projector, "Business");
138137
constraint.SetAllowedLayers(new[] { "Business" }); // Sealed: only self
@@ -155,7 +154,7 @@ public async Task LayerConstraint_IntraLayerDependency_AlwaysAllowedAsync()
155154
{
156155
new Edge("src/Business/ServiceA.cs", "src/Business/ServiceB.cs", External: false, new[] { ImportKind.Using })
157156
};
158-
var graph = new Graph(edges);
157+
var graph = new ArchUnitNet.Common.Extraction.Graph(edges);
159158
var projector = new LayerProjector("src/{Layer}/**");
160159
var constraint = new LayerConstraint(graph, projector, "Business");
161160
constraint.SetAllowedLayers(new List<string>()); // No external dependencies allowed
@@ -191,7 +190,7 @@ public async Task LayerConstraint_BlocklistBeforeAllowlist_BlocklistWinsAsync()
191190
{
192191
new Edge("src/Presentation/Component.cs", "src/Utility/Helper.cs", External: false, new[] { ImportKind.Using })
193192
};
194-
var graph = new Graph(edges);
193+
var graph = new ArchUnitNet.Common.Extraction.Graph(edges);
195194
var projector = new LayerProjector("src/{Layer}/**");
196195
var constraint = new LayerConstraint(graph, projector, "Presentation");
197196
constraint.SetForbiddenLayers(new[] { "Utility" });
@@ -210,7 +209,7 @@ public async Task LayerConstraint_BlocklistBeforeAllowlist_BlocklistWinsAsync()
210209
public async Task LayerConstraint_EmptyTestGuard_WithNoLayersAndNoAllowEmptyTests_FailsAsync()
211210
{
212211
// Arrange: Empty graph, no layers exist
213-
var graph = new Graph(new List<Edge>());
212+
var graph = new ArchUnitNet.Common.Extraction.Graph(new List<Edge>());
214213
var projector = new LayerProjector("src/{Layer}/**");
215214
var constraint = new LayerConstraint(graph, projector, "Presentation");
216215

@@ -228,7 +227,7 @@ public async Task LayerConstraint_EmptyTestGuard_WithNoLayersAndNoAllowEmptyTest
228227
public async Task LayerConstraint_EmptyTestGuard_WithAllowEmptyTests_PassesAsync()
229228
{
230229
// Arrange: Empty graph with AllowEmptyTests option
231-
var graph = new Graph(new List<Edge>());
230+
var graph = new ArchUnitNet.Common.Extraction.Graph(new List<Edge>());
232231
var projector = new LayerProjector("src/{Layer}/**");
233232
var constraint = new LayerConstraint(graph, projector, "Presentation");
234233
var options = new CheckOptions { AllowEmptyTests = true };
@@ -249,7 +248,7 @@ public async Task LayerConstraint_MultipleViolations_ReturnAllAsync()
249248
new Edge("src/Presentation/ComponentA.cs", "src/Data/RepositoryA.cs", External: false, new[] { ImportKind.Using }),
250249
new Edge("src/Presentation/ComponentB.cs", "src/Data/RepositoryB.cs", External: false, new[] { ImportKind.Using })
251250
};
252-
var graph = new Graph(edges);
251+
var graph = new ArchUnitNet.Common.Extraction.Graph(edges);
253252
var projector = new LayerProjector("src/{Layer}/**");
254253
var constraint = new LayerConstraint(graph, projector, "Presentation");
255254
constraint.SetForbiddenLayers(new[] { "Data" });

‎tests/ArchUnitNet.Tests/Layers/LayersConditionBuilderTests.cs‎

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,12 @@
44
using ArchUnitNet.Layers.Common;
55
using ArchUnitNet.Layers.FluentApi;
66
using Xunit;
7-
using Graph = ArchUnitNet.Common.Extraction.Graph;
87

98
namespace ArchUnitNet.Tests.Layers;
109

1110
public class LayersConditionBuilderTests
1211
{
13-
private static Graph CreateSimpleLayeredGraph()
12+
private static ArchUnitNet.Common.Extraction.Graph CreateSimpleLayeredGraph()
1413
{
1514
// Create a 3-layer architecture: Presentation -> Business -> Data
1615
var edges = new List<Edge>
@@ -22,7 +21,7 @@ private static Graph CreateSimpleLayeredGraph()
2221
// Data layer
2322
new Edge("src/Data/Repository.cs", "System.Data.SqlClient", External: true, new[] { ImportKind.Using })
2423
};
25-
return new Graph(edges);
24+
return new ArchUnitNet.Common.Extraction.Graph(edges);
2625
}
2726

2827
[Fact]
@@ -185,7 +184,7 @@ public async Task FluentApi_MayOnlyDependOn_InvalidArchitectureAsync()
185184
{
186185
new Edge("src/Presentation/Component.cs", "src/Data/Repository.cs", External: false, new[] { ImportKind.Using })
187186
};
188-
var constraint = ProjectLayers.From(new Graph(edges))
187+
var constraint = ProjectLayers.From(new ArchUnitNet.Common.Extraction.Graph(edges))
189188
.DefinedBy("src/{Layer}/**")
190189
.Where(new Layer("Presentation"))
191190
.MayOnlyDependOn(new Layer("Business"));
@@ -221,7 +220,7 @@ public async Task FluentApi_MayNotDependOn_InvalidAsync()
221220
{
222221
new Edge("src/Presentation/Component.cs", "src/Data/Repository.cs", External: false, new[] { ImportKind.Using })
223222
};
224-
var constraint = ProjectLayers.From(new Graph(edges))
223+
var constraint = ProjectLayers.From(new ArchUnitNet.Common.Extraction.Graph(edges))
225224
.DefinedBy("src/{Layer}/**")
226225
.Where(new Layer("Presentation"))
227226
.MayNotDependOn(new Layer("Data"));
@@ -242,7 +241,7 @@ public async Task FluentApi_SealedLayer_AllowsIntraLayerOnlyAsync()
242241
{
243242
new Edge("src/Data/RepositoryA.cs", "src/Data/RepositoryB.cs", External: false, new[] { ImportKind.Using })
244243
};
245-
var constraint = ProjectLayers.From(new Graph(edges))
244+
var constraint = ProjectLayers.From(new ArchUnitNet.Common.Extraction.Graph(edges))
246245
.DefinedBy("src/{Layer}/**")
247246
.Where(new Layer("Data"))
248247
.MayOnlyDependOn(); // Sealed
@@ -260,7 +259,7 @@ public async Task FluentApi_EmptyPattern_WithAllowEmptyTestsAsync()
260259
// Arrange: No matching layers, but AllowEmptyTests is true
261260
var edges = new List<Edge>();
262261
var options = new CheckOptions { AllowEmptyTests = true };
263-
var constraint = ProjectLayers.From(new Graph(edges))
262+
var constraint = ProjectLayers.From(new ArchUnitNet.Common.Extraction.Graph(edges))
264263
.DefinedBy("src/{Layer}/**")
265264
.Where(new Layer("Presentation"))
266265
.MayOnlyDependOn(new Layer("Business"));

0 commit comments

Comments
 (0)