Skip to content

Issues in Chrome Extension context #5

Description

@multimeric

You're currently compiling this as a UMD (which is great), however the gulp UMD seems to output this:

;(function(root, factory) {
  if (typeof define === 'function' && define.amd) {
    define([], factory);
  } else if (typeof exports === 'object') {
    module.exports = factory();
  } else {
    root.Puz = factory();
  }
}(this, function() {
// Code
}));

I suppose this works fine in the browser, since this is bound to window, but Chrome extensions don't seem to have a value for this, causing this entire module to fail to load.

Happening with puzjs@1.0.2.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions