Skip to content

Clean up e2e test for linux #8

@ehmatthes

Description

@ehmatthes

On Linux, need to use shell=True, and whole commands instead of parts. There are a bunch of conditional tests for Linux, that can be simplified.

  • Update make_sp_call() in core e2e test utils to accept use_parts arg.
  • Simplify existing checks about Windows, heroku, etc. make_sp_call() should not do any of that inspection.
  • Simplify calls in e2e test utils for this plugin with the updated core test utility function.
  • See also core issue 405, about removing use of shell=True.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions