Skip to content

units.Position (word choice?) #22

@tweber225

Description

@tweber225

To describe unit quantities with dimension [length], I initially named this class Position. I think I was working on the Stage class, so it made sense then. However, most of the time when we need units of this dimension we're not really talking about absolute position, but rather some relative length measurement. For instance pixel_size, frame_height--these really aren't "positions" in any sense.

To remedy this, we could

  1. change units.Position -> units.Length throughout
  2. retain units.Position and make an additional units.Length class that's just an alias of units.Position. Then users can choose which descriptor makes most sense.

Option 1 is easy, but we may lose some type descriptiveness for quantities that truly are positions
Option 2 seems to make redundant code

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions