fix(devframe): advertise wss for a shared TLS server

Author: erkamyaman

packages/devframe/src/adapters/__tests__/initiate.test.ts

@@ -1,6 +1,7 @@
 import type { DevframeNodeContext, DevframeRpcClientFunctions, DevframeRpcServerFunctions } from '../../types'
 import { mkdtempSync, writeFileSync } from 'node:fs'
 import { createServer } from 'node:http'
+import { createSecureServer } from 'node:http2'
 import { tmpdir } from 'node:os'
 import { join } from 'node:path'
 import { defineDevframe } from 'devframe'
@@ -10,6 +11,7 @@ import { getPort } from 'get-port-please'
 import { describe, expect, it, vi } from 'vitest'
 import { WebSocket } from 'ws'
 import { getTempAuthCode } from '../../node/auth/state'
+import { getInternalContext } from '../../node/hub-internals/context'
 import { initDevframe } from '../initiate'
 
 const HANDSHAKE = { authToken: '', ua: 'test', origin: 'http://localhost' }
@@ -206,6 +208,30 @@ describe('adapters/handler', () => {
     }
   })
 
+  it('shared-server tier: a TLS host server advertises wss://', async () => {
+    const host = '127.0.0.1'
+    const server = createSecureServer({ allowHTTP1: true })
+    await new Promise<void>(resolve => server.listen(0, host, resolve))
+    const { port } = server.address() as { port: number }
+    const devtools = initDevframe(defineTestDef('handler-tls'), {
+      base: '/__handler-tls/',
+      auth: false,
+      host,
+      server: server as any,
+    })
+
+    try {
+      await devtools.ready
+      expect(getInternalContext(await devtools.context).wsEndpoint).toEqual({
+        url: `wss://localhost:${port}/__handler-tls/__ws`,
+      })
+    }
+    finally {
+      await devtools.close()
+      await new Promise<void>(resolve => server.close(() => resolve()))
+    }
+  })
+
   it('ws.url tier: advertises the external endpoint verbatim, owns no transport', async () => {
     const devtools = initDevframe(defineTestDef('handler-remote'), { base: '/__handler-remote/', ws: { url: 'wss://devtools.example.com/relay/__ws' } })
 

packages/devframe/src/node/instance-shell.ts

@@ -14,6 +14,7 @@ import type { DevframeInstanceRecord, DevframeInstanceRegistration } from './ins
 import type { ContextRpcServer } from './rpc-core'
 import { createServer } from 'node:http'
 import process from 'node:process'
+import { Server as TlsServer } from 'node:tls'
 import { validateOriginCandidate } from 'devframe/utils/origin'
 import { joinURL, withLeadingSlash, withoutLeadingSlash, withoutTrailingSlash } from 'devframe/utils/url'
 import { defineHandler, H3 as H3App, toNodeHandler } from 'h3'
@@ -143,9 +144,12 @@ async function bindHttpAndWs(options: BindHttpAndWsOptions): Promise<StartedServ
 
   const address = httpServer.address()
   const resolvedPort = typeof address === 'object' && address ? address.port : port
-  const origin = normalizeHttpServerUrl(bindHost, resolvedPort)
+  const secure = httpServer instanceof TlsServer
+  const origin = secure
+    ? `https://${formatHostForUrl(bindHost)}:${resolvedPort}`
+    : normalizeHttpServerUrl(bindHost, resolvedPort)
   const internal = getInternalContext(context)
-  const wsUrl = `ws://${formatHostForUrl(bindHost)}:${resolvedPort}${options.path ?? ''}`
+  const wsUrl = `${secure ? 'wss' : 'ws'}://${formatHostForUrl(bindHost)}:${resolvedPort}${options.path ?? ''}`
   if (websocket)
     internal.setWsEndpoint({ url: wsUrl })