fix(plugin-terminals): adapt to upstream main (nostics v1, required metadata, per-package typecheck)

Merge upstream/main and reconcile the plugin with its newer baseline:
- resolve to nostics ^1.1.4 via the catalog and regenerate the lockfile
  (fixes the broken merged lockfile that failed frozen CI installs).
- supply the now-required DevframeDefinition metadata (version,
  packageName, homepage, description) from package.json.
- add a `typecheck` script and switch tsconfig to explicit include/exclude
  (drop composite) so `turbo run typecheck` passes for the package.
- refresh tsnapi snapshots for the nostics v1 diagnostics handle shape.

Author: antfubot

plugins/terminals/package.json

@@ -44,6 +44,7 @@
     "watch": "tsdown --watch",
     "dev": "node bin.mjs",
     "test": "vitest run",
+    "typecheck": "tsc --noEmit",
     "prepack": "pnpm run build"
   },
   "peerDependencies": {

plugins/terminals/src/index.ts

@@ -2,6 +2,7 @@ import type { DevframeDefinition } from 'devframe/types'
 import type { TerminalsOptions } from './types'
 import { fileURLToPath } from 'node:url'
 import { defineDevframe } from 'devframe/types'
+import pkg from '../package.json' with { type: 'json' }
 import {
   DEFAULT_PORT,
   PLUGIN_ID,
@@ -40,6 +41,10 @@ export function createTerminalsDevframe(options: TerminalsOptions = {}): Devfram
   return defineDevframe({
     id: PLUGIN_ID,
     name: 'Terminals',
+    version: pkg.version,
+    packageName: pkg.name,
+    homepage: pkg.homepage,
+    description: pkg.description,
     icon: 'ph:terminal-window-duotone',
     // Leave undefined so `resolveBasePath` picks `/` standalone and
     // `/__<id>/` when hosted. Authors override via `options.basePath`.

plugins/terminals/tsconfig.json

@@ -1,7 +1,8 @@
 {
   "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    "composite": true,
     "lib": ["esnext", "dom"]
-  }
+  },
+  "include": ["src", "test", "tsdown.config.ts"],
+  "exclude": ["dist", "node_modules"]
 }

tests/__snapshots__/tsnapi/@devframes/plugin-terminals/index.snapshot.js

@@ -1,16 +1,12 @@
 /**
  * Generated by tsnapi — public API snapshot of `@devframes/plugin-terminals`
  */
-// #region Functions
-export function createTerminalsDevframe(_) {}
-// #endregion
-
 // #region Default Export
-var _default /* const */
-export default _default
+export default terminals
 // #endregion
 
 // #region Other
+export { createTerminalsDevframe }
 export { DEFAULT_PORT }
 export { PLUGIN_ID }
 export { PRESETS_STATE_KEY }

tests/__snapshots__/tsnapi/@devframes/plugin-terminals/node.snapshot.d.ts

@@ -44,38 +44,43 @@ export declare function setupTerminals(_: DevframeNodeContext, _?: TerminalsOpti
 // #endregion
 
 // #region Variables
-export declare const diagnostics: {
-  readonly DP_TERMINALS_0001: _$nostics.DiagnosticHandle<{
-    id: string;
-  }, {
-    method?: "log" | "warn" | "error" | undefined;
-  }>;
-  readonly DP_TERMINALS_0002: _$nostics.DiagnosticHandle<{
-    command: string;
-  }, {
-    method?: "log" | "warn" | "error" | undefined;
-  }>;
-  readonly DP_TERMINALS_0003: _$nostics.DiagnosticHandle<{
-    id: string;
-  }, {
-    method?: "log" | "warn" | "error" | undefined;
-  }>;
-  readonly DP_TERMINALS_0004: _$nostics.DiagnosticHandle<{
-    command: string;
-    reason: string;
-  }, {
-    method?: "log" | "warn" | "error" | undefined;
-  }>;
-  readonly DP_TERMINALS_0005: _$nostics.DiagnosticHandle<{}, {
-    method?: "log" | "warn" | "error" | undefined;
-  }>;
-  readonly DP_TERMINALS_0006: _$nostics.DiagnosticHandle<{
-    id: string;
-  }, {
-    method?: "log" | "warn" | "error" | undefined;
-  }>;
-  readonly DP_TERMINALS_0007: _$nostics.DiagnosticHandle<{}, {
-    method?: "log" | "warn" | "error" | undefined;
-  }>;
-};
+export declare const diagnostics: _$nostics.Diagnostics<{
+  readonly DP_TERMINALS_0001: {
+    readonly why: (p: {
+      id: string;
+    }) => string;
+    readonly fix: "Spawn a session first, or refresh the session list.";
+  };
+  readonly DP_TERMINALS_0002: {
+    readonly why: (p: {
+      command: string;
+    }) => string;
+    readonly fix: "Add it to `presets`, or pass `allowArbitraryCommands: true` to createTerminalsDevframe().";
+  };
+  readonly DP_TERMINALS_0003: {
+    readonly why: (p: {
+      id: string;
+    }) => string;
+    readonly fix: "Spawn the session with `mode: \"interactive\"` to accept input.";
+  };
+  readonly DP_TERMINALS_0004: {
+    readonly why: (p: {
+      command: string;
+      reason: string;
+    }) => string;
+  };
+  readonly DP_TERMINALS_0005: {
+    readonly why: "PTY backend (@homebridge/node-pty-prebuilt-multiarch) is unavailable; interactive sessions fall back to a piped child process. Full-screen TUIs may not render correctly.";
+    readonly fix: "Install @homebridge/node-pty-prebuilt-multiarch to enable real pseudo-terminals.";
+  };
+  readonly DP_TERMINALS_0006: {
+    readonly why: (p: {
+      id: string;
+    }) => string;
+  };
+  readonly DP_TERMINALS_0007: {
+    readonly why: "Terminals manager is not initialised on this context";
+    readonly fix: "Call setupTerminals(ctx) (or use createTerminalsDevframe) before invoking terminal RPCs.";
+  };
+}, readonly [typeof reporter]>;
 // #endregion