diff --git a/docs/review/LESSONS.md b/docs/review/LESSONS.md index 849c94c8c..9164b0abd 100644 --- a/docs/review/LESSONS.md +++ b/docs/review/LESSONS.md @@ -23,10 +23,10 @@ reviews can cite them, and each number is in exactly one file | Area | Files | Entries | Read for | | --- | --- | --- | --- | -| Safety model (AGENTS.md section 1) | [`safety.md`](lessons/safety.md), [`safety-2.md`](lessons/safety-2.md), [`safety-3.md`](lessons/safety-3.md) | 103 | every review | +| Safety model (AGENTS.md section 1) | [`safety.md`](lessons/safety.md), [`safety-2.md`](lessons/safety-2.md), [`safety-3.md`](lessons/safety-3.md) | 104 | every review | | Shared code and the reference device | [`shared-code.md`](lessons/shared-code.md), [`shared-code-2.md`](lessons/shared-code-2.md) | 94 | omarchy-mobile and app pull requests | | Shell and scripts | [`shell.md`](lessons/shell.md), [`shell-2.md`](lessons/shell-2.md) | 88 | omarchy-mobile and app pull requests | -| Kernel (linux-omarchy-mobile) | [`kernel.md`](lessons/kernel.md), [`kernel-2.md`](lessons/kernel-2.md) | 122 | linux-omarchy-mobile pull requests | +| Kernel (linux-omarchy-mobile) | [`kernel.md`](lessons/kernel.md), [`kernel-2.md`](lessons/kernel-2.md) | 123 | linux-omarchy-mobile pull requests | | The gates themselves | [`gates.md`](lessons/gates.md), [`gates-2.md`](lessons/gates-2.md) | 92 | every review | | Reviews and merging | [`reviews.md`](lessons/reviews.md), [`reviews-2.md`](lessons/reviews-2.md) | 107 | every review | | Claims and evidence | [`claims.md`](lessons/claims.md), [`claims-2.md`](lessons/claims-2.md), [`claims-3.md`](lessons/claims-3.md) | 169 | every review | diff --git a/docs/review/lessons/kernel.md b/docs/review/lessons/kernel.md index f95d178fa..2217370a0 100644 --- a/docs/review/lessons/kernel.md +++ b/docs/review/lessons/kernel.md @@ -3,6 +3,19 @@ Part of [the review lessons](../LESSONS.md), which says how they are used and how they grow. +- **L-777. A device that runs vendor firmware on untrusted input, enabled with + its IOMMU in bypass, is a security decision for the maintainer, and stock's + device tree says what confines it.** #250's MFC parses browser video with + Google's closed firmware and DMA to all RAM below 4 GiB; stock's + `gs201-mfc.dtsi` puts two System MMUs and `samsung,tzmp` in front of it, and + `gs201-s2mpu.dtsi` two S2MPUs. The maintainer's decision (2026-11-15): such a + node stays `disabled`, and an omarchy-mobile overlay turns it on, until the + IOMMU is described. *Check:* for any new DMA master a board enables, grep + Google's SoC dtsi for its `iommus`, `s2mpu` and `tzmp` lines, say what + confines it in our tree (an IOMMU, a restricted pool, nothing), and ask for + the node disabled with an overlay unless something confines it. Extends the + Wi-Fi restricted-pool decision and L-2. *From:* kernel #250, round 57, + 2026-11-14. - **L-766. A boot argument a board PR adds for safety is grepped against that device's bring-up overlays, because an overlay's `/chosen/bootargs` replaces the whole string.** Husky's `klog.dtso` and `panic-probe.dtso` (and akita's diff --git a/docs/review/lessons/safety.md b/docs/review/lessons/safety.md index 8b1528809..fa5b53f7a 100644 --- a/docs/review/lessons/safety.md +++ b/docs/review/lessons/safety.md @@ -3,6 +3,17 @@ Part of [the review lessons](../LESSONS.md), which says how they are used and how they grow. +- **L-776. A helper that "falls back to the old path on failure" is checked + against every exception the transport under it raises, not only the ones + the tests inject.** #754's `reconcile()` caught `ModemError`, `TimeoutError` + and `OSError`, while `Sit.request()` also raises a bare `RuntimeError` and + `EOFError`; either one skipped the unconfirmed release's radio-off that the + helper sits in front of, and all of the PR's tests stayed green. *Check:* + `grep -n 'raise ' ` for every exception class the helper's call + can raise, then run the PR's fixture with each as the side effect and count + the safety calls on main and on the head; prefer `except Exception` + returning "not handled". Extends L-757 and L-716. *From:* #754, round 57, + 2026-11-14. - **L-757. A safety or recovery call that a PR puts behind a selector or a helper is run with the selector wrong and with a stop arriving mid-start, and the hardware calls are counted on main and on the head.** #669's profile