From cc604317f3972d70bc8b0b022165002633de592e Mon Sep 17 00:00:00 2001 From: Derek Ross Date: Wed, 11 Nov 2026 18:07:43 -0500 Subject: [PATCH] omamobile-shell: the notification store test skips without node, as the other node tests do test/notifications-store.sh (#482) runs NotificationsModel.js under node with no check for it, so test/all failed on ms01, which has no node, and the development publish stopped at omamobile-shell 0.2.125 on 2026-11-11. Every other node test in test/all skips there; this one now does too. CI has node and still runs it. Run on ms01 with the change: the test reports SKIP and the rest of test/all goes on. Co-Authored-By: Claude Fable 5.2 --- packages/omamobile-shell/test/all | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/omamobile-shell/test/all b/packages/omamobile-shell/test/all index 744ada761..1a41a1b11 100755 --- a/packages/omamobile-shell/test/all +++ b/packages/omamobile-shell/test/all @@ -300,7 +300,13 @@ grep -cF '"/.local/state/omarchy/notifications/history.json"' plugins/omamobile. # Omarchy 4.0's files and 4.5's live.json and history.json, chosen by what # exists: test/notifications-store.sh runs the shade's own commands on both. grep -cF '"sh", Quickshell.shellDir, root.notificationsDir].concat(notificationFiles)' "$qs" >/dev/null || fail "Clear all hands every notification read to the clear script" -bash test/notifications-store.sh >/dev/null || { bash test/notifications-store.sh; fail "the shade reads and clears both notification layouts"; } +# It runs NotificationsModel.js under node, which a build machine may lack +# (ms01's publish, 2026-11-11); CI has it. +if command -v node >/dev/null; then + bash test/notifications-store.sh >/dev/null || { bash test/notifications-store.sh; fail "the shade reads and clears both notification layouts"; } +else + pass "the shade reads and clears both notification layouts # SKIP no node" +fi grep -cF 'call omamobile.bar notificationsSeen' "$qs" >/dev/null || fail "the shade tells the bar what it has shown" grep -cF 'function notificationsSeen(stamp: string): string' plugins/omamobile.bar/Bar.qml >/dev/null || fail "the bar serves notificationsSeen" grep -cF '"/.local/state/omamobile/notifications-seen"' plugins/omamobile.bar/Bar.qml >/dev/null || fail "the bar reads the shade's mark at start"