From bfc9bc02a3a79dd81bd2924d219dd7c81d5a6e09 Mon Sep 17 00:00:00 2001 From: Marsel Nenaj <201385099+marselnenaj@users.noreply.github.com> Date: Mon, 9 Nov 2026 20:45:13 +0100 Subject: [PATCH] omamobile-modem-sit: explain the SMSC probe failure policy Document why a failed or empty SMSC reply is incomplete with a present SIM, while the no-SIM error remains an expected result. Follow up on the review of #569 without changing probe behavior or its package version. Co-Authored-By: OpenAI Codex --- packages/omamobile-modem-sit/lib/service.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/omamobile-modem-sit/lib/service.py b/packages/omamobile-modem-sit/lib/service.py index df2dc7dfb..62a737100 100644 --- a/packages/omamobile-modem-sit/lib/service.py +++ b/packages/omamobile-modem-sit/lib/service.py @@ -842,7 +842,11 @@ def serve_one(service, connection, clients): def probe(): """Read-only first contact (MODEM-PLAN M4.1): SIM card and application states, radio state, packet registration, NR mode, whether an SMSC is - set. No identifiers are printed; nothing is changed.""" + set. No identifiers are printed; nothing is changed. + + A failed/empty SMSC reply with a present SIM leaves SMS configuration + unverified; SMSC error 11 is expected only when no SIM is present. + """ client = Sit() failed = False try: