From 08453349520334a964ff36ad1fe4fea93adef816 Mon Sep 17 00:00:00 2001 From: divybot Date: Sat, 13 Jun 2026 14:37:04 +0530 Subject: [PATCH] fix(test): expect legacy-abort deprecation warning in request_signal_streaming The `serve::request_signal_streaming` spec test (added in #35049) and the legacy-abort deprecation warning (added in #34397) landed in parallel and collided on main: the test exercises legacy abort with a handler that accesses `request.signal` and returns successfully, which is exactly the case #34397 now warns about. Neither PR saw the other, so main has been failing `test specs ... request_signal_streaming` on every commit since #34397. The warning is correct and expected for this scenario, so update the test's expected output to include it. Verified the warning is emitted deterministically as the first line. --- tests/specs/serve/request_signal_streaming/main.out | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/specs/serve/request_signal_streaming/main.out b/tests/specs/serve/request_signal_streaming/main.out index 289f53a216a603..6a206b2fd408fa 100644 --- a/tests/specs/serve/request_signal_streaming/main.out +++ b/tests/specs/serve/request_signal_streaming/main.out @@ -1,3 +1,4 @@ +Deno.serve: request.signal aborts on successful responses (legacy behavior, see https://github.com/denoland/deno/issues/29111). Move cleanup to the handler's return path, or opt in to the new behavior with --unstable-no-legacy-abort. See https://docs.deno.com/runtime/reference/migrate-deprecations/ body: chunk1;chunk2;chunk3;chunk4;chunk5; aborted during stream: false aborted after completion: true