From 494407491a26a7e8973ec87eee2d4d7e411e9870 Mon Sep 17 00:00:00 2001 From: Matus Kasak Date: Tue, 10 Mar 2026 14:53:40 +0100 Subject: [PATCH 1/2] Changed id to class --- cypress/e2e/header.cy.ts | 1 - src/app/search-navbar/search-navbar.component.html | 2 +- src/app/search-navbar/search-navbar.component.spec.ts | 8 ++++---- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/cypress/e2e/header.cy.ts b/cypress/e2e/header.cy.ts index f2437a687a9..4fe53f7e5ac 100644 --- a/cypress/e2e/header.cy.ts +++ b/cypress/e2e/header.cy.ts @@ -12,7 +12,6 @@ describe('Header', () => { // testA11y({ // include: ['ds-header'], // exclude: [ - // ['#search-navbar-container'], // search in navbar has duplicative ID. Will be fixed in #1174 // ['.dropdownLogin'] // "Log in" link has color contrast issues. Will be fixed in #1149 // ], // }); diff --git a/src/app/search-navbar/search-navbar.component.html b/src/app/search-navbar/search-navbar.component.html index 02a98905021..c60e1139594 100644 --- a/src/app/search-navbar/search-navbar.component.html +++ b/src/app/search-navbar/search-navbar.component.html @@ -1,4 +1,4 @@ -
+
{ spyOn(component, 'expand').and.callThrough(); spyOn(component, 'onSubmit').and.callThrough(); spyOn(router, 'navigate'); - const searchIcon = fixture.debugElement.query(By.css('#search-navbar-container form .submit-icon')); + const searchIcon = fixture.debugElement.query(By.css('.search-navbar-container form .submit-icon')); searchIcon.triggerEventHandler('click', { preventDefault: () => {/**/ } @@ -88,7 +88,7 @@ describe('SearchNavbarComponent', () => { describe('empty query', () => { describe('press submit button', () => { beforeEach(fakeAsync(() => { - const searchIcon = fixture.debugElement.query(By.css('#search-navbar-container form .submit-icon')); + const searchIcon = fixture.debugElement.query(By.css('.search-navbar-container form .submit-icon')); searchIcon.triggerEventHandler('click', { preventDefault: () => {/**/ } @@ -109,14 +109,14 @@ describe('SearchNavbarComponent', () => { beforeEach(async () => { await fixture.whenStable(); fixture.detectChanges(); - searchInput = fixture.debugElement.query(By.css('#search-navbar-container form input')); + searchInput = fixture.debugElement.query(By.css('.search-navbar-container form input')); searchInput.nativeElement.value = 'test'; searchInput.nativeElement.dispatchEvent(new Event('input')); fixture.detectChanges(); }); describe('press submit button', () => { beforeEach(fakeAsync(() => { - const searchIcon = fixture.debugElement.query(By.css('#search-navbar-container form .submit-icon')); + const searchIcon = fixture.debugElement.query(By.css('.search-navbar-container form .submit-icon')); searchIcon.triggerEventHandler('click', null); tick(); fixture.detectChanges(); From 5b41037c84ca911306b628867776bc7700401936 Mon Sep 17 00:00:00 2001 From: Matus Kasak Date: Tue, 10 Mar 2026 17:56:47 +0100 Subject: [PATCH 2/2] Fix duplicate id license_option --- .../clarin-license-resource/section-license.component.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/app/submission/sections/clarin-license-resource/section-license.component.html b/src/app/submission/sections/clarin-license-resource/section-license.component.html index 9ed6b046259..17680d2662d 100644 --- a/src/app/submission/sections/clarin-license-resource/section-license.component.html +++ b/src/app/submission/sections/clarin-license-resource/section-license.component.html @@ -64,11 +64,11 @@ -