IPFS Resolution for NBA Assets#301
Merged
Merged
Conversation
sid42
commented
Apr 3, 2026
Comment on lines
+847
to
+854
| items.append( | ||
| MetadataViews.Media( | ||
| file: MetadataViews.HTTPFile( | ||
| url: TopShotIPFSResolver.gateway.concat(cid) | ||
| ), | ||
| mediaType: mediaType | ||
| ) | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
Resolving to the IPFS HTTP Gateway for convenience
fkenji
approved these changes
Apr 3, 2026
Contributor
Author
|
These contract changes have been made in mainnet TopShot Contract Upgrade: https://www.flowscan.io/tx/ec7db8a262ccb7781bb3367a77deb75ceb71af478f16aca031e7ece0b26c8a34?tab=events TopShotIPFSResolver Contract Addition: https://www.flowscan.io/tx/887d5746518484bf08a35b70494f395ed43345cbd48aed59500dc30d346331b2?tab=script |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IPFS CIDs for NBA assets have already been uploaded: https://dapperlabs.github.io/dapperlabs-ipfs-reference-app/. There's also a store in NBA's backend to associate all the assets for a given
(play_id, set_id, subedtion_id)tuple.A separate job would be needed for the backfill from NBA BE into the new
TopShotIPFSResolvercontractExpected resolution on
MetadataViews.Medias(sourced from forked mainnet testing on emulator usingget_topshot_nft_media_views.cdc)