From 89edab284fcdc28926b81d80a536da258caef7a9 Mon Sep 17 00:00:00 2001 From: Derek Mackley Date: Fri, 20 Nov 2026 20:52:53 -0600 Subject: [PATCH 1/2] even section spacing, a readable header name and socials in the hero on phones --- .../css/design-system/tokens/spacing.css | 19 +++++++++++++++++++ .../atoms/HeaderName/HeaderName.css | 10 +++++++--- .../atoms/HeaderName/HeaderName.test.tsx | 4 ++-- .../atoms/HeaderName/HeaderName.tsx | 2 +- src/components/layout/Section/Section.css | 13 ++----------- src/components/layout/Section/Section.tsx | 4 ++-- .../molecules/SocialLinks/SocialLinks.css | 6 ++++++ .../SocialLinks/SocialLinks.stories.tsx | 18 ++++++++++++++++++ .../molecules/SocialLinks/SocialLinks.tsx | 6 ++++-- .../ClusterTelemetry/ClusterTelemetry.css | 6 +++--- .../organisms/Education/Education.css | 9 ++++----- .../organisms/Experience/Experience.css | 15 +++++---------- .../organisms/GithubProfile/GithubProfile.tsx | 2 +- .../organisms/Greetings/Greetings.css | 11 ++++++++++- .../organisms/Greetings/Greetings.tsx | 9 +++++++++ .../organisms/Projects/Projects.css | 11 +---------- src/components/organisms/Skills/Skills.css | 4 ---- 17 files changed, 94 insertions(+), 55 deletions(-) diff --git a/src/assets/css/design-system/tokens/spacing.css b/src/assets/css/design-system/tokens/spacing.css index aef92135..61db8a3c 100644 --- a/src/assets/css/design-system/tokens/spacing.css +++ b/src/assets/css/design-system/tokens/spacing.css @@ -13,6 +13,11 @@ --spacing-10: 5rem; /* Semantic Spacing */ + /* Vertical rhythm: padding on each side of a section, and the gap between a + section header and its content. Tighter on phones, roomier on desktop; + the vw caps keep it from doubling with large text. */ + --section-gap: min(1.5rem, 8vw); + --section-header-gap: min(1.5rem, 6.2vw); --section-padding-y: var(--spacing-8); --section-padding-y-sm: var(--spacing-6); --container-padding-x: min(var(--spacing-6), 8.3vw); @@ -22,3 +27,17 @@ --button-padding-x: var(--spacing-4); --button-padding-y: var(--spacing-2); } + +@media (min-width: 768px) { + :root { + --section-gap: min(2.5rem, 8vw); + --section-header-gap: min(2rem, 6.2vw); + } +} + +@media (min-width: 1024px) { + :root { + --section-gap: min(4rem, 8vw); + --section-header-gap: min(2.5rem, 6.2vw); + } +} diff --git a/src/components/atoms/HeaderName/HeaderName.css b/src/components/atoms/HeaderName/HeaderName.css index 7f7f3277..ef111e66 100644 --- a/src/components/atoms/HeaderName/HeaderName.css +++ b/src/components/atoms/HeaderName/HeaderName.css @@ -145,20 +145,24 @@ noscript ~ * .cursor { /* Signature: one line, sized by the viewport so large text cannot wrap it */ .header-name__title { - font-size: min(1.75rem, 8vw); + font-family: var(--font-family-jetbrains); + font-weight: var(--font-weight-semibold); + letter-spacing: -0.01em; + color: var(--color-primary); + font-size: min(1.125rem, 5vw); line-height: 1.1; white-space: nowrap; } @media (min-width: 640px) { .header-name__title { - font-size: min(2rem, 7vw); + font-size: min(1.5rem, 5vw); } } @media (min-width: 1024px) { .header-name__title { - font-size: min(2.5rem, 6vw); + font-size: min(1.875rem, 5vw); } } diff --git a/src/components/atoms/HeaderName/HeaderName.test.tsx b/src/components/atoms/HeaderName/HeaderName.test.tsx index 473ca409..5bc23aae 100644 --- a/src/components/atoms/HeaderName/HeaderName.test.tsx +++ b/src/components/atoms/HeaderName/HeaderName.test.tsx @@ -6,7 +6,7 @@ import HeaderName from './HeaderName'; // Mock CSS imports to avoid actual CSS loading in tests vi.mock('./HeaderName.css', () => ({ - default: '.cyber-text-animation { font-family: Agustina; }' + default: '.cyber-text-animation { font-family: monospace; }' })); describe('HeaderName Component', () => { @@ -56,7 +56,7 @@ describe('HeaderName Component', () => { expect(element).toHaveClass('relative', 'cyber-text-animation'); }); - it('uses the Agustina font', () => { + it('uses the mono name style', () => { const { container } = render(); const element = container.firstChild as HTMLElement; // Since we're mocking the CSS, we'll check for the class instead diff --git a/src/components/atoms/HeaderName/HeaderName.tsx b/src/components/atoms/HeaderName/HeaderName.tsx index c2fe8341..948bcc88 100644 --- a/src/components/atoms/HeaderName/HeaderName.tsx +++ b/src/components/atoms/HeaderName/HeaderName.tsx @@ -41,7 +41,7 @@ const HeaderName: React.FC = ({ onHoverEnd={() => controls.start('initial')} >

diff --git a/src/components/layout/Section/Section.css b/src/components/layout/Section/Section.css index edf75be9..597582b3 100644 --- a/src/components/layout/Section/Section.css +++ b/src/components/layout/Section/Section.css @@ -7,9 +7,8 @@ .section { position: relative; - padding: min(6rem, 25vw) 0; + padding: var(--section-gap) 0; background: transparent; - min-height: 50vh; overflow: hidden; } @@ -19,7 +18,7 @@ z-index: 10; text-align: left; max-width: var(--container-max-width); - margin: 0 auto min(var(--spacing-8), 12.4vw); + margin: 0 auto var(--section-header-gap); padding: 0 0 min(var(--spacing-5), 6.2vw); border-bottom: 1px solid rgba(var(--color-cyan-rgb), 0.2); } @@ -71,10 +70,6 @@ } @media (max-width: 768px) { - .section { - padding: min(3rem, 12.4vw) 0; - } - .section-title { font-size: min(var(--font-size-2xl), 8vw); } @@ -82,10 +77,6 @@ .section-subtitle { font-size: var(--font-size-base); } - - .section .section-content { - padding: min(1.5rem, 6.2vw) 0; - } } .section:focus, diff --git a/src/components/layout/Section/Section.tsx b/src/components/layout/Section/Section.tsx index 076e34bf..981a947b 100644 --- a/src/components/layout/Section/Section.tsx +++ b/src/components/layout/Section/Section.tsx @@ -95,7 +95,7 @@ const Section = ({ const contentWrapper = (content: React.ReactNode) => ( {content} @@ -103,7 +103,7 @@ const Section = ({ // Content with optional container const content = container ? ( -
+
{sectionHeader} { + const canvas = within(canvasElement); + await expect(canvas.getByLabelText('GitHub Profile').parentElement).toHaveClass('social-links--large'); + }, +}; diff --git a/src/components/molecules/SocialLinks/SocialLinks.tsx b/src/components/molecules/SocialLinks/SocialLinks.tsx index 4de5d179..17898653 100644 --- a/src/components/molecules/SocialLinks/SocialLinks.tsx +++ b/src/components/molecules/SocialLinks/SocialLinks.tsx @@ -14,6 +14,8 @@ export interface SocialLinksProps { animated?: boolean; /** Profile URLs and the vCard to download; an icon shows only if its link is given */ links?: Partial; + /** `large` makes each icon a 44px touch target, for phones */ + size?: 'default' | 'large'; } /** @@ -22,7 +24,7 @@ export interface SocialLinksProps { * * @component */ -const SocialLinks = ({ className = '', animated = true, links = {} }: SocialLinksProps) => { +const SocialLinks = ({ className = '', animated = true, links = {}, size = 'default' }: SocialLinksProps) => { const socialLinks = links; const shouldAnimate = useMotionEnabled(animated); @@ -70,7 +72,7 @@ const SocialLinks = ({ className = '', animated = true, links = {} }: SocialLink return ( { variants={slideUpVariants} initial={animationEnabled ? "hidden" : "visible"} animate="visible" - className="mt-8" + className="" > { > Download Resume + {/* The nav shows these from lg up; phones get them here */} +
diff --git a/src/components/organisms/Projects/Projects.css b/src/components/organisms/Projects/Projects.css index f40740c3..9e4697c7 100644 --- a/src/components/organisms/Projects/Projects.css +++ b/src/components/organisms/Projects/Projects.css @@ -2,17 +2,13 @@ * Projects Styles */ -.projects-section { - padding: min(var(--section-padding-y), 12.4vw) 0; -} - .projects-grid { display: grid; /* At most two columns: the cards carry long descriptions, and an even number of projects lays out as a clean grid */ grid-template-columns: repeat(auto-fill, minmax(min(100%, max(18.75rem, calc(50% - var(--spacing-5)))), 1fr)); gap: min(var(--spacing-5), 6.2vw); - margin-top: min(var(--spacing-6), 8.3vw); + margin-top: 0; } .projects-grid-loading { @@ -130,13 +126,8 @@ } @media (max-width: 768px) { - .projects-section { - padding: min(var(--section-padding-y-sm), 8.3vw) 0; - } - .projects-grid { gap: min(var(--spacing-3), 3.1vw); - margin-top: min(var(--spacing-4), 4.2vw); } } diff --git a/src/components/organisms/Skills/Skills.css b/src/components/organisms/Skills/Skills.css index 7abc2008..23b7da1b 100644 --- a/src/components/organisms/Skills/Skills.css +++ b/src/components/organisms/Skills/Skills.css @@ -190,10 +190,6 @@ /* Media queries for responsive design */ @media (max-width: 768px) { - .skills-container, - .terminal-container { - margin-bottom: 2rem; - } /* Phone layout: the old overrides here shrank card text below 9px, and the nested paddings left about 120px of usable width. */ From 402a75fcdf8ae11f73ea3cae4796f4189e035964 Mon Sep 17 00:00:00 2001 From: Derek Mackley Date: Fri, 20 Nov 2026 21:08:22 -0600 Subject: [PATCH 2/2] grow the hero terminal with the screen on desktop --- .../organisms/Greetings/Greetings.css | 45 +++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/src/components/organisms/Greetings/Greetings.css b/src/components/organisms/Greetings/Greetings.css index c0e7f8f8..1a4d4907 100644 --- a/src/components/organisms/Greetings/Greetings.css +++ b/src/components/organisms/Greetings/Greetings.css @@ -70,4 +70,49 @@ .greetings .greetings__socials { display: none; } + + /* On desktop the terminal grows with the screen so the hero reads as a + full-size window, not a small card floating in the middle. */ + .greetings__inner { + max-width: min(72rem, 70vw); + } + + .greetings .terminal-window { + max-width: none; + } + + .greetings .terminal-window__body { + padding: clamp(1.25rem, 1.6vw, 2rem); + } + + .greetings__title { + font-size: clamp(2.5rem, 3.4vw, 4.25rem); + } + + .greetings .terminal-window__log, + .greetings .terminal-window__input-row, + .greetings .terminal-window__input { + font-size: clamp(1rem, 1.05vw, 1.375rem); + } + + .greetings .terminal-window__log { + min-height: min(18rem, 34svh); + max-height: min(30rem, 50svh); + } + + .greetings .terminal-window__chip { + padding: var(--spacing-2) var(--spacing-4); + font-size: clamp(0.8125rem, 0.8vw, 1.0625rem); + } +} + +/* Big monitors: keep the window in proportion instead of capping at 72rem */ +@media (min-width: 1800px) { + .greetings__inner { + max-width: min(96rem, 66vw); + } + + .greetings .terminal-window__log { + min-height: min(26rem, 38svh); + } }