Skip to content

Refactor LibraryService.__init__: too many parameters (S107) #172

@danielcopper

Description

@danielcopper

Problem

LibraryService.__init__ has 14 parameters (self + 13 keyword-only), exceeding the S107 threshold of 13. This is a pre-existing issue, not a regression.

Suggested Fix

Group the three persistence/logging callbacks (save_state, save_settings_to_disk, log_debug) into a small config object or Protocol, reducing the param count by 2.

Alternatively, evaluate if some params can be consolidated or injected differently via bootstrap.

Area

Backend, Architecture

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions