-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
area:architectureCode structure, refactoringCode structure, refactoringarea:savesSave file syncSave file sync
Description
Problem
SaveService.save_state() (saves.py:143-152) reimplements the same flock + tmp + replace pattern that PersistenceAdapter._locked_write already provides. This is code duplication — the locked-write pattern exists in exactly two places.
Proposed Solution
Route save_sync_state.json through PersistenceAdapter like all other state files. Either:
- Add
save_save_sync_state/load_save_sync_statemethods to PersistenceAdapter - Or extract the locked-write pattern into a shared utility that both use
Priority
P0 — architecture hygiene, part of refactoring sprint
Area
Architecture, Saves
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area:architectureCode structure, refactoringCode structure, refactoringarea:savesSave file syncSave file sync