[BUG] cleanup_tmpfiles in installer.sh does not clear tmp dir

[jeremydelattre59]

Hi,
I can see that rollback for my issue #1868 :
revert: rollback installer tmpfile refactor

So, cleanup_tmpfiles function does not clear tmp dir.

Perhaps the solution is to name tmp dir always dagu-installer.* and in cleanup_tmpfiles function remove all dagu-installer.* directories ?

mktempdir() {
local d
if [[ -n "${WORKING_ROOT_DIR:-}" ]]; then
mkdir -p "${WORKING_ROOT_DIR}" >/dev/null 2>&1 || true
d="$(mktemp -p ${WORKING_ROOT_DIR%/} -d "dagu-installer.XXXXXX")"
else
d="$(mktemp -p /tmp -d "dagu-installer.XXXXXX")"
fi
printf '%s\n' "$d"
}

cleanup_tmpfiles() {
rm -rf "${WORKING_ROOT_DIR}/dagu-installer." 2>/dev/null
rm -rf "/tmp/dagu-installer." 2>/dev/null
}

[yottahmd]

Yes, thank you for flagging this. I found some issues in the script and had to rollback to make it work again. Will try to fix again.