From f883f6ece0999e3f1aa39d164b527706e82914f6 Mon Sep 17 00:00:00 2001
From: Cyrus <86699936+cyrusae@users.noreply.github.com>
Date: Sat, 23 May 2026 21:14:05 -0700
Subject: [PATCH] fix: atomic config writes; release v0.1.0

---
 entangle/.chainlink/.cache/last-edit-time |   2 +-
 entangle/.chainlink/issues.db             | Bin 167936 -> 167936 bytes
 entangle/Cargo.lock                       |   2 +-
 entangle/Cargo.toml                       |   2 +-
 entangle/src/config.rs                    |  59 +++++++++++++++++++---
 5 files changed, 56 insertions(+), 9 deletions(-)

diff --git a/entangle/.chainlink/.cache/last-edit-time b/entangle/.chainlink/.cache/last-edit-time
index f08f8f5..64425df 100644
--- a/entangle/.chainlink/.cache/last-edit-time
+++ b/entangle/.chainlink/.cache/last-edit-time
@@ -1 +1 @@
-1779594594.8513
\ No newline at end of file
+1779595965.963836
\ No newline at end of file
diff --git a/entangle/.chainlink/issues.db b/entangle/.chainlink/issues.db
index c77dec1c49ec20a4a85ff785e9cf1db62f4954ee..ad0ce2f4d52bbf6f8ecddc78578657d525d9f43e 100644
GIT binary patch
delta 857
zcmZ{iv2W8r6vlmaTQ_Oqq(g>MQ{7MrP;28jX&Vdzs!C-FVn7|bxK473PdK*ay95eI
zX+<j}1_bJmHAqYhNGL;wPF)aFhAv1f{0kkrf_QZVRH97h^Y?q-z4zVi^pZQh<eOP^
z{8n8<$Dg)dUdMBSAfytMu@+%MQj})U=vz&Lpelz4vaup6hy7{%Oi53v5}H*b;t_|D
z{+HXgkfbWT1Nkl>JwUb;B|U~_(QicUf4sl(4w&JAd;-i6nAb{TQp%wqB);1J`cs<*
z`Lru%(PdFN9n5FZQ0e}dLz74yz#@a3+3d;&S`jmwP<|=X-MWLuL{%NY`rZJ!)s@3D
zxdrl4W_(N%p!R78y*kNGq%<M3s%)pfrOT<Klm^61s<S(-P6@jSA(s=%Wnq;EO<Ki|
zBgzS`2NA9Yew{Y-h+*cmiOmB$bhvvHS6a;ww@Jik;A0+OL(l8R*&HryxTaw)YsQjh
z79Sc#E1$Q_CB0yp#ge&T7?xq2({mRBgQMr-nv|W8_Js6@sqx9r^8C0i?Lo(()Om4b
zE&;uw{d<CN&grjFez{c4|8vrrUa;~jdZAb<E#DaF>N<TwYS{Vj*cNtbwLgRn!E`vW
zN2y?!cp-`KRZf~=oqEKkK3>4^i&4fGA+aXG5Emzrj~#{^ltYl$u;bToL_*K0f-&PY
z%c?WW8f6X+m4Lf=EzaGt&Ziz1K3I1mP95(eK*y_bvvCo;%Qj)QAJ|?{ePqY|RftRB
za84NSe%}yh$~rC>X1r(6DPz=cEaIvYH3A&ADjsDn*0fr*twk*#SHThn;h6Z`@f#k|
Tnly^wk+kF6*9ZE(c%1wN7cl;o

delta 226
zcmZozz}2vTYl1Z6*@-gFjAu6{wCgL#GB7akaAp=4m!=joa4|7UGD6tWyg&(Qz7vz#
z4a_$SDs=H}K4E9W$SlpbZZf+ANTh&o@&Z5B&71uK7Xn4EPiFrB5}nC6`P@H_&G-MQ
z3Iav{PG=Wjl-;f-z<7>tVgUE{zjBQ1Kym(r>FfrKAmvK@+Y{^=mly!Ws;09SfW>V1
zw^!9Oc75Pu<vGZ}@5ooldyChX=O9q^dY<hEYnYsw`B+)?7<gB4vvM3`S7Fry%E+*8
K*K1|E#03B}U_xC0

diff --git a/entangle/Cargo.lock b/entangle/Cargo.lock
index 4f96b9a..a1b2b90 100644
--- a/entangle/Cargo.lock
+++ b/entangle/Cargo.lock
@@ -339,7 +339,7 @@ dependencies = [
 
 [[package]]
 name = "entangle-mirror"
-version = "0.1.0-alpha.1"
+version = "0.1.0"
 dependencies = [
  "clap",
  "dialoguer",
diff --git a/entangle/Cargo.toml b/entangle/Cargo.toml
index ed8354d..8754111 100644
--- a/entangle/Cargo.toml
+++ b/entangle/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "entangle-mirror"
-version = "0.1.0-alpha.1"
+version = "0.1.0"
 edition = "2024"
 description = "Easy setup for mirroring GitHub repos to Tangled.org in one command"
 license = "MIT"
diff --git a/entangle/src/config.rs b/entangle/src/config.rs
index b0e167a..9ca6982 100644
--- a/entangle/src/config.rs
+++ b/entangle/src/config.rs
@@ -240,11 +240,43 @@ impl PartialConfig {
         let json = serde_json::to_string_pretty(self)
             .expect("PartialConfig serialization should never fail");
 
-        std::fs::write(path, json).map_err(ConfigError::CannotWriteFile)?;
+        atomic_write_config(path, &json)?;
         Ok(())
     }
 }
 
+// ---------------------------------------------------------------------------
+// Atomic write helper
+// ---------------------------------------------------------------------------
+
+/// Write `content` to `path` atomically using a unique temp file in the same
+/// directory, then rename.
+///
+/// The caller is responsible for ensuring the parent directory already exists
+/// (both [`Config::save_to_path`] and [`PartialConfig::save_to_path`] call
+/// `create_dir_all` before reaching here). The temp file is created with a
+/// `.lock` suffix so tools that watch the config directory can recognise it
+/// as an in-progress write. If this function returns an error the temp file
+/// is cleaned up automatically by `tempfile`'s `Drop` implementation.
+fn atomic_write_config(path: &Path, content: &str) -> Result<(), ConfigError> {
+    use std::io::Write as _;
+    let dir = path.parent().ok_or_else(|| {
+        ConfigError::CannotWriteFile(std::io::Error::new(
+            std::io::ErrorKind::InvalidInput,
+            "config path has no parent directory",
+        ))
+    })?;
+    let mut tmp = tempfile::Builder::new()
+        .suffix(".lock")
+        .tempfile_in(dir)
+        .map_err(ConfigError::CannotWriteFile)?;
+    tmp.write_all(content.as_bytes())
+        .map_err(ConfigError::CannotWriteFile)?;
+    tmp.persist(path)
+        .map_err(|e| ConfigError::CannotWriteFile(e.error))?;
+    Ok(())
+}
+
 // ---------------------------------------------------------------------------
 // Error types
 // ---------------------------------------------------------------------------
@@ -489,11 +521,10 @@ impl Config {
         let json =
             serde_json::to_string_pretty(self).expect("Config serialization should never fail");
 
-        // ── 3. Write atomically-ish via a newline-terminated string ──────────
-        // We write the complete serialized string in one call; partial writes
-        // are unlikely on local filesystems but the worst case is a
-        // re-run of `entangle setup`, not data loss in the repo.
-        std::fs::write(path, json).map_err(ConfigError::CannotWriteFile)?;
+        // ── 3. Write atomically ──────────────────────────────────────────────
+        // Uses a unique temp file in the same directory + rename so a crash
+        // mid-write never leaves the config in a truncated state.
+        atomic_write_config(path, &json)?;
 
         Ok(())
     }
@@ -747,6 +778,22 @@ mod tests {
 
     // ── Save ─────────────────────────────────────────────────────────────────
 
+    #[test]
+    fn save_leaves_no_lock_file_behind() {
+        // atomic_write_config uses a temp file with a .lock suffix; it must
+        // be renamed (not left on disk) after a successful write.
+        let f = NamedTempFile::new().unwrap();
+        let path = f.path();
+        let lock_path = path.with_extension("lock");
+
+        valid_config().save_to_path(path).unwrap();
+
+        assert!(
+            !lock_path.exists(),
+            "no .lock file should remain after a successful save"
+        );
+    }
+
     #[test]
     fn save_creates_parent_directory_if_missing() {
         // Create a temp dir, then point save() at a nested path that doesn't exist yet.