From f17a5bf4158a52d8c97dc2737df9373041ee6a4c Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 10 Nov 2026 14:26:23 +0000 Subject: [PATCH 1/2] fix(local): build local commands on Windows and macOS again Removing the Linux-only containment module left its cfg(target_os = "linux") attribute on the following lines, so mod exec and the LocalExec export disappeared off Linux and the Windows installer stopped compiling. Two error variants only built by the unix descriptor setup are now gated to unix, which also clears the dead-code warning there. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01WAgRyZqRCp4XuUHFDB1w3k --- crates/local/src/lib.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/local/src/lib.rs b/crates/local/src/lib.rs index cc295fa5..119a878d 100644 --- a/crates/local/src/lib.rs +++ b/crates/local/src/lib.rs @@ -30,7 +30,6 @@ use nocterm_session::{ use portable_pty::{CommandBuilder, PtySize as NativeSize, native_pty_system}; mod clock; -#[cfg(target_os = "linux")] mod exec; mod integration; mod program_opener; @@ -39,7 +38,6 @@ mod readiness; mod recording; pub use clock::SystemClock; -#[cfg(target_os = "linux")] pub use exec::LocalExec; pub use program_opener::{LocalProgramOpener, MAX_OPEN_PROGRAMS}; pub use recording::LocalOutputLogFactory; @@ -208,8 +206,10 @@ enum LaunchError { Source(#[from] nocterm_session::ConnectionSourceError), #[error("native PTY error: {0}")] Pty(String), + #[cfg(unix)] #[error("native PTY has no file descriptor")] MissingFd, + #[cfg(unix)] #[error("file descriptor control error: {0}")] Fcntl(String), #[error("I/O error: {0}")] From a67b4a161e29a9864bca69fbeebdca954ca819d2 Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 10 Nov 2026 14:26:23 +0000 Subject: [PATCH 2/2] ci: check that the application builds for Windows Installers ship for Windows, but no pull request job compiled the application there, so a Linux-only gate reached release validation first. The Windows native job now also runs cargo check -p nocterm. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01WAgRyZqRCp4XuUHFDB1w3k --- .github/workflows/ci.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5e1cc416..f0a8cc54 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -357,8 +357,10 @@ jobs: if: ${{ !cancelled() }} run: cargo test --manifest-path vendor/gpui-component/Cargo.toml --locked --features test-support --lib menu::app_menu_bar + # Installers ship for Windows, so a pull request also checks that the whole application + # builds there; release validation would otherwise be the first to compile it. device-unlock-native: - name: Device unlock on ${{ matrix.os }} + name: Native build on ${{ matrix.os }} strategy: fail-fast: false matrix: @@ -383,6 +385,9 @@ jobs: run: cargo clippy --locked -p nocterm-vault -p nocterm-vault-store -p nocterm-device-unlock --all-targets -- -D warnings - name: Test portable envelope and native metadata without authentication prompts run: cargo test --locked -p nocterm-vault -p nocterm-vault-store -p nocterm-device-unlock + - name: Check the application builds for Windows + if: runner.os == 'Windows' + run: cargo check --locked -p nocterm # The one check to require in branch protection: it passes only when every # job above passed or was skipped by design, so adding a job never needs a