fix: three minor bugs in Context, Filters, and Provider#425
Open
toddr-bot wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Recreated from #371 (auto-closed when the |
Member
|
@toddr-bot rebase |
1. Provider::_load_compiled error message used $compiled (undef on
failure) instead of $fpath, causing "uninitialized value" warnings.
2. Context::process() and insert() debug calls had join(', ') with no
list argument — the template names were passed as separate args to
debug() instead of being comma-joined.
3. Redirect filter path traversal check only caught '../' with trailing
slash. Now also catches '..' alone, 'foo/..' without trailing slash,
and Windows-style backslash separators.
Added 3 test cases for redirect path traversal.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The _assign() method in Stash.pm used hash access ($root->{ $item })
instead of array access ($root->[$item]) when checking if a list element
already has a value for the DEFAULT directive. This meant DEFAULT on
array indices would always overwrite instead of preserving existing
values, because $root->{ $item } on an arrayref doesn't find the
existing value.
Added tests for DEFAULT on array elements (existing and new indices).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
Rebase with requested adjustmentsBranch StatsActions performed
CI statusCI will be checked asynchronously. Automated by Kōan |
toddr-bot
force-pushed
the
koan.toddr.bot/fix-minor-bugs
branch
from
44dfea0 to
2dbc70a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix four bugs across Context.pm, Filters.pm, Provider.pm, and Stash.pm.
Why
_load_compiled()error message uses$compiled(undef on failure) instead of$fpath, causing "uninitialized value" warnings (relates to GH Strange bug not sure the cause #280).join(', ')in debug output forprocess()andinsert()is missing its list argument...traversal check only matched../with trailing slash. Bare..,foo/.., and Windows..\\bypassed it._assign()used hash access$root->{ $item }instead of array access$root->[$item]when checking DEFAULT on list elements. This caused DEFAULT to always overwrite array values.How
$compiled→$fpathin error string.join(', ')→join(', ', @$template)/join(', ', @$files).(^|/)\.\./→(^|[\\/])\.\.([\\/]|$).$root->{ $item }→$root->[$item]in the ARRAY branch of_assign().Testing
🤖 Generated with Claude Code