fix: pyenv init on linux

Author: kevinwang5658

src/resources/python/pyenv/global-parameter.ts

@@ -1,6 +1,6 @@
 import { getPty, ParameterSetting, SpawnStatus, StatefulParameter } from '@codifycli/plugin-core';
 
-import { PyenvConfig } from './pyenv.js';
+import { PYENV_INIT_INLINE, PyenvConfig } from './pyenv.js';
 
 export class PyenvGlobalParameter extends StatefulParameter<PyenvConfig, string>{
 
@@ -13,7 +13,7 @@ export class PyenvGlobalParameter extends StatefulParameter<PyenvConfig, string>
   override async refresh(): Promise<null | string> {
     const $ = getPty();
 
-    const { data, status } = await $.spawnSafe('pyenv global')
+    const { data, status } = await $.spawnSafe(`${PYENV_INIT_INLINE} pyenv global`, { interactive: true })
     if (status === SpawnStatus.ERROR) {
       return null;
     }
@@ -23,16 +23,16 @@ export class PyenvGlobalParameter extends StatefulParameter<PyenvConfig, string>
 
   override async add(valueToAdd: string): Promise<void> {
     const $ = getPty();
-    await $.spawn(`pyenv global ${valueToAdd}`, { interactive: true })
+    await $.spawn(`${PYENV_INIT_INLINE} pyenv global ${valueToAdd}`, { interactive: true })
   }
 
   override async modify(newValue: string): Promise<void> {
     const $ = getPty();
-    await $.spawn(`pyenv global ${newValue}`, { interactive: true })
+    await $.spawn(`${PYENV_INIT_INLINE} pyenv global ${newValue}`, { interactive: true })
   }
 
   override async remove(): Promise<void> {
     const $ = getPty();
-    await $.spawn('pyenv global system', { interactive: true })
+    await $.spawn(`${PYENV_INIT_INLINE} pyenv global system`, { interactive: true })
   }
 }

src/resources/python/pyenv/pyenv.ts

@@ -15,6 +15,11 @@ export interface PyenvConfig extends ResourceConfig {
   // TODO: Add option here to use homebrew to install instead. Default to true. Maybe add option to set default values to resource config.
 }
 
+// pyenv is a real binary on PATH (unlike nvm, which is a sourced shell function), so every
+// command that invokes it must set up PATH inline rather than assuming a prior interactive
+// shell already sourced the rc lines added by addPyenvInitialization().
+export const PYENV_INIT_INLINE = 'export PYENV_ROOT="$HOME/.pyenv"; [ -d "$PYENV_ROOT/bin" ] && export PATH="$PYENV_ROOT/bin:$PATH"; eval "$(pyenv init -)" 2>/dev/null;';
+
 const defaultConfig: Partial<PyenvConfig> = {
   pythonVersions: [],
 }
@@ -60,7 +65,7 @@ export class PyenvResource extends Resource<PyenvConfig> {
   override async refresh(): Promise<Partial<PyenvConfig> | null> {
     const $ = getPty();
 
-    const pyenvVersion = await $.spawnSafe('pyenv --version')
+    const pyenvVersion = await $.spawnSafe(`${PYENV_INIT_INLINE} pyenv --version`, { interactive: true })
     if (pyenvVersion.status === SpawnStatus.ERROR) {
       return null
     }
@@ -101,7 +106,7 @@ export class PyenvResource extends Resource<PyenvConfig> {
   override async destroy(): Promise<void> {
     const $ = getPty();
 
-    await $.spawn('rm -rf $(pyenv root)', { interactive: true });
+    await $.spawn(`${PYENV_INIT_INLINE} rm -rf $(pyenv root)`, { interactive: true });
     await $.spawn('rm -rf $HOME/.pyenv');
 
     await FileUtils.removeLineFromStartupFile('export PYENV_ROOT="$HOME/.pyenv"')
@@ -120,7 +125,7 @@ export class PyenvResource extends Resource<PyenvConfig> {
   // TODO: Need to support bash in addition to zsh here
   private async isValidInstall(): Promise<boolean> {
     const $ = getPty();
-    const { data: doctor } = await $.spawnSafe('pyenv doctor', { interactive: true })
+    const { data: doctor } = await $.spawnSafe(`${PYENV_INIT_INLINE} pyenv doctor`, { interactive: true })
     return doctor.includes('Congratulations! You are ready to build pythons!');
   }
 }

src/resources/python/pyenv/python-versions-parameter.ts

@@ -1,12 +1,12 @@
 import { ArrayStatefulParameter, getPty, SpawnStatus } from '@codifycli/plugin-core';
 
-import { PyenvConfig } from './pyenv.js';
+import { PYENV_INIT_INLINE, PyenvConfig } from './pyenv.js';
 
 export class PythonVersionsParameter extends ArrayStatefulParameter<PyenvConfig, string> {
   override async refresh(desired: string[]): Promise<string[] | null> {
     const $ = getPty();
 
-    const { data } = await $.spawnSafe('pyenv versions --bare --skip-aliases --skip-envs')
+    const { data } = await $.spawnSafe(`${PYENV_INIT_INLINE} pyenv versions --bare --skip-aliases --skip-envs`, { interactive: true })
 
     const versions = data.split(/\n/)
       .map((l) => l.trim())
@@ -16,7 +16,7 @@ export class PythonVersionsParameter extends ArrayStatefulParameter<PyenvConfig,
     // reason behind this is that pyenv does special version processing during installs. For ex: specifying
     // pyenv install 3 will install the latest version 3.12.2
     for (const desiredVersion of desired ?? []) {
-      const { status, data } = await $.spawnSafe(`pyenv latest ${desiredVersion}`);
+      const { status, data } = await $.spawnSafe(`${PYENV_INIT_INLINE} pyenv latest ${desiredVersion}`, { interactive: true });
 
       if (status !== SpawnStatus.SUCCESS) {
         continue;
@@ -35,11 +35,11 @@ export class PythonVersionsParameter extends ArrayStatefulParameter<PyenvConfig,
 
   override async addItem(version: string): Promise<void> {
     const $ = getPty();
-    await $.spawn(`pyenv install ${version} -s`, { interactive: true });
+    await $.spawn(`${PYENV_INIT_INLINE} pyenv install ${version} -s`, { interactive: true });
   }
 
   override async removeItem(version: string): Promise<void> {
     const $ = getPty();
-    await $.spawn(`pyenv uninstall ${version} -f`, { interactive: true });
+    await $.spawn(`${PYENV_INIT_INLINE} pyenv uninstall ${version} -f`, { interactive: true });
   }
 }