Made updateRenderState async and render to nothing first to avoid memory crashes.

Improved the progress output for destroy

Author: kevinwang5658

src/commands/apply.ts

@@ -43,14 +43,14 @@ For more information, visit: https://codifycli.com/docs/commands/apply
     '<%= config.bin %> <%= command.id %> -S <sudo password>',
   ]
 
-  async init(): Promise<void> {
-    console.log('Running Codify apply...')
-    return super.init();
-  }
-
   public async run(): Promise<void> {
     const { flags, args } = await this.parse(Apply)
 
+
+    if (flags.output !== 'json') {
+      console.log('Running Codify apply...')
+    }
+
     if (flags.path && args.pathArgs) {
       throw new Error('Cannot specify both --path and path argument');
     }

src/commands/destroy.ts

@@ -39,18 +39,18 @@ For more information, visit: https://codifycli.com/docs/commands/destory`
       default: false,
     }),
   }
-  
+
   public async run(): Promise<void> {
     const { flags, raw } = await this.parse(Destroy)
 
+    if (flags.output !== 'json') {
+      console.log('Running Codify destroy...')
+    }
+
     const args = raw
       .filter((r) => r.type === 'arg')
       .map((r) => r.input);
 
-    if (flags.path) {
-      this.log(`Applying Codify from: ${flags.path}`);
-    }
-
     await DestroyOrchestrator.run({
       verbosityLevel: flags.debug ? 3 : 0,
       typeIds: args,

src/orchestrators/destroy.ts

@@ -21,7 +21,7 @@ export class DestroyOrchestrator {
 
   static async run(args: DestroyArgs, reporter: Reporter) {
     const typeIds = args.typeIds?.filter(Boolean)
-    ctx.processStarted(ProcessName.DESTROY)
+    ctx.processStarted(ProcessName.PLAN)
 
     const initializationResult = await PluginInitOrchestrator.run(
       { ...args, allowEmptyProject: true, },
@@ -37,6 +37,8 @@ export class DestroyOrchestrator {
       ? await DestroyOrchestrator.destroyExistingProject(reporter, initializationResult)
       : await DestroyOrchestrator.destroySpecificResources(typeIds, reporter, initializationResult)
 
+    ctx.processFinished(ProcessName.DESTROY)
+
     plan.sortByEvalOrder(project.evaluationOrder);
     destroyProject.removeNoopFromEvaluationOrder(plan);
 
@@ -55,6 +57,8 @@ export class DestroyOrchestrator {
       }
     }
 
+    ctx.processStarted(ProcessName.DESTROY)
+
     const filteredPlan = plan.filterNoopResources()
 
     let currentVerbosity = args.verbosityLevel ?? 0;

src/ui/reporters/default-reporter.tsx

@@ -88,7 +88,7 @@ export class DefaultReporter implements Reporter {
       RenderEvent.PROMPT_RESULT,
     )
 
-    this.updateRenderState(previousRenderState.status, previousRenderState.data);
+    await this.updateRenderState(previousRenderState.status, previousRenderState.data);
   }
 
   async displayInitBanner(): Promise<void> {
@@ -106,11 +106,11 @@ export class DefaultReporter implements Reporter {
   }
 
   async displayProgress(): Promise<void> {
-    this.updateRenderState(RenderStatus.PROGRESS);
+    await this.updateRenderState(RenderStatus.PROGRESS);
   }
 
   async hide(): Promise<void> {
-    this.updateRenderState(RenderStatus.NOTHING);
+    await this.updateRenderState(RenderStatus.NOTHING);
   }
 
   async displayImportWarning(requiresParameters: string[], noParametersRequired: string[]): Promise<void> {
@@ -173,7 +173,7 @@ export class DefaultReporter implements Reporter {
     exitFullScreen()
     process.off('beforeExit', exitFullScreen);
 
-    this.updateRenderState(RenderStatus.PROGRESS);
+    await this.updateRenderState(RenderStatus.PROGRESS);
 
     return userInput.map((v) => ResourceConfig.fromJson({
       core: { type: v.section.title },
@@ -195,7 +195,7 @@ export class DefaultReporter implements Reporter {
     store.set(store.progressState, null);
     this.progressState = null;
 
-    this.updateRenderState(RenderStatus.DISPLAY_IMPORT_RESULT, { importResult, showConfigs });
+    void this.updateRenderState(RenderStatus.DISPLAY_IMPORT_RESULT, { importResult, showConfigs });
   }
 
   async promptSudo(pluginName: string, data: CommandRequestData, secureMode: boolean): Promise<string | undefined> {
@@ -212,11 +212,11 @@ export class DefaultReporter implements Reporter {
   }
 
   displayPlan(plan: Plan): void {
-    this.updateRenderState(RenderStatus.DISPLAY_PLAN, plan)
+    void this.updateRenderState(RenderStatus.DISPLAY_PLAN, plan)
   }
 
   displayMessage(message: string) {
-    this.updateRenderState(RenderStatus.DISPLAY_MESSAGE, message);
+    void this.updateRenderState(RenderStatus.DISPLAY_MESSAGE, message);
   }
 
   async promptInitResultSelection(availableTypes: string[]): Promise<string[]> {
@@ -234,12 +234,6 @@ export class DefaultReporter implements Reporter {
 
     this.log(result ? `${message} -> "Yes"` : `${message} -> "No"`)
 
-    // This was added because there was a very hard to debug memory bug with Yoga (ink.js layout engine). Could not
-    // identify the root cause of the problem but this alleviates it.
-    await sleep(50)
-    this.updateRenderState(RenderStatus.NOTHING, null);
-    await sleep(50);
-
     return result;
   }
 
@@ -253,17 +247,13 @@ export class DefaultReporter implements Reporter {
 
     this.log(`${message} -> "${result}"`)
 
-    // This was added because there was a very hard to debug memory bug with Yoga (ink.js layout engine). Could not
-    // identify the root cause of the problem but this alleviates it.
-    await sleep(50)
-    this.updateRenderState(prevRenderState.status, prevRenderState.data);
-    await sleep(50);
+    await this.updateRenderState(prevRenderState.status, prevRenderState.data);
 
     return options.indexOf(result);
   }
 
   displayFileModifications(diff: Array<{ file: string; modification: FileModificationResult}>) {
-    this.updateRenderState(RenderStatus.DISPLAY_FILE_MODIFICATION, diff);
+    void this.updateRenderState(RenderStatus.DISPLAY_FILE_MODIFICATION, diff);
   }
 
   private log(args: string): void {
@@ -326,18 +316,14 @@ export class DefaultReporter implements Reporter {
   private async handleInlineSudoPassword(): Promise<void> {
     let attemptCount = 0;
 
-    await sleep(50);
-    this.updateRenderState(RenderStatus.NOTHING);
-    await sleep(50);
-
     while (attemptCount < 3) {
       const result = (await Promise.all([
         this.updateRenderState(RenderStatus.SUDO_PROMPT, { attemptCount, cancellable: true }),
         Promise.race([
           this.awaitEvent<string>(RenderEvent.SUDO_PROMPT_RESULT),
           this.awaitEvent<'cancel'>(RenderEvent.SUDO_PASSWORD_CANCEL).then(() => Symbol.for('cancel')),
         ]),
-      ])).at(1) as string | Symbol;
+      ])).at(1) as string | symbol;
 
       if (result === Symbol.for('cancel')) {
         ctx.log('Sudo password cancelled');
@@ -346,13 +332,10 @@ export class DefaultReporter implements Reporter {
         ctx.log('Sudo password attempt');
       }
 
-      const isValid = this.sudoPasswordSubmittedCallback?.(result) ?? false;
+      const isValid = this.sudoPasswordSubmittedCallback?.(result as string) ?? false;
       if (isValid) {
         ctx.log('Sudo password successful!');
 
-        await sleep(50);
-        this.updateRenderState(RenderStatus.NOTHING, null);
-        await sleep(50);
         await this.displayProgress();
         this.renderEmitter.emit(RenderEvent.SUDO_PASSWORD_PRE_SUPPLIED);
         return;
@@ -363,18 +346,12 @@ export class DefaultReporter implements Reporter {
     }
 
     // Cancelled or all attempts exhausted — restore progress display
-    await sleep(50);
-    this.updateRenderState(RenderStatus.NOTHING, null);
-    await sleep(50);
     await this.displayProgress();
   }
 
   private async getUserPassword(): Promise<string> {
     let attemptCount = 0;
 
-    this.updateRenderState(RenderStatus.NOTHING);
-    await sleep(50);
-
     while (attemptCount < 3) {
       const passwordAttempt = await this.updateStateAndAwaitEvent<string>(
         () => this.updateRenderState(RenderStatus.SUDO_PROMPT, { attemptCount, cancellable: false }),
@@ -404,7 +381,12 @@ export class DefaultReporter implements Reporter {
     return store.get(store.renderState) as { status: RenderStatus, data: any };
   }
 
-  private updateRenderState(status: RenderStatus | null, data?: unknown): void {
+  private async updateRenderState(status: RenderStatus | null, data?: unknown): Promise<void> {
+    const current = this.getRenderState();
+    if (current?.status !== status) {
+      store.set(store.renderState, { status: RenderStatus.NOTHING, data: null });
+      await sleep(50);
+    }
     store.set(store.renderState, { status, data });
   }