From d7e7d1070fb91d0681c2d598d58e8ea8b2e72869 Mon Sep 17 00:00:00 2001 From: ajianaz Date: Sun, 18 Oct 2026 11:57:46 +0700 Subject: [PATCH] chore(ci): raise the Cora Review job timeout from 10 to 30 minutes Diffs of a few hundred lines already exceed the 10-minute limit: the job is cancelled mid-review and no verdict is posted, which blocks the merge gate (seen three times on #407). Sync the stated limit in AGENTS.md and CONTRIBUTING.md. --- .github/workflows/cora-review.yml | 4 +++- AGENTS.md | 6 +++--- CONTRIBUTING.md | 5 ++--- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/.github/workflows/cora-review.yml b/.github/workflows/cora-review.yml index d887ebe..432de07 100644 --- a/.github/workflows/cora-review.yml +++ b/.github/workflows/cora-review.yml @@ -18,7 +18,9 @@ jobs: cora-review: name: Cora Review runs-on: ubuntu-latest - timeout-minutes: 10 + # PRs of 850+ lines need ~16 min of review; 10 min cancelled them + # mid-review with no verdict. + timeout-minutes: 30 steps: - name: Checkout PR head uses: actions/checkout@v7 diff --git a/AGENTS.md b/AGENTS.md index ffd9df1..1ee1848 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -40,9 +40,9 @@ continuity, infra facts. verdict in the PR comments ("✅ No issues found" or concrete findings — "Review could not complete" is a blocker), code-scanning alerts investigated (real → fix with regression test; FP → dismiss with - evidence), CI auto-fix max 3 attempts then escalate. Large change-sets - (~40+ files) time out Cora Review (10-min limit) — split into ~15–20-file - PRs. + evidence), CI auto-fix max 3 attempts then escalate. The Cora Review job + has a 30-min limit; large change-sets (~40+ files or ~850+ lines) can still + time out — split into ~15–20-file PRs. ## 3. Mandatory pre-commit checks diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index cd141c5..4521623 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -32,9 +32,8 @@ workflow; the ecosystem-wide standards it follows live in the team knowledge roo ## Pull requests -- One logical change per PR; large change-sets (~40+ files) deterministically - time out the Cora Review job (10-minute hard limit) — split into ~15–20-file - PRs. +- One logical change per PR; large change-sets (~40+ files) can time out the + Cora Review job (30-minute limit) — split into ~15–20-file PRs. - Body sections, in order: **What / Why / Changes / Testing**. A PR without them fails the PR Description check. - Base every PR on `develop`. PRs into `main` are only accepted from