Skip to content

Commit b4b5ebe

Browse files
codeasiercodeasier
andauthored
fix: remove hardcoded 10-row limit from query output, add -n flag (#51)
Query results were always truncated to first 10 rows with no way to retrieve the full list. Change default to unlimited output and add a -n flag to optionally limit displayed rows. Fixes #49 Co-authored-by: codeasier <codeasier@codeasiers-MacBook-Air.local>
1 parent a6eaf6e commit b4b5ebe

6 files changed

Lines changed: 53 additions & 22 deletions

File tree

‎docs/en/querying.md‎

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -64,15 +64,26 @@ Parameters:
6464

6565
## Output Format
6666

67-
Results display as a list:
68-
- Shows first 10 results
69-
- If more than 10, shows remaining count
67+
All results are displayed by default. Use `-n` to limit the number of rows shown:
7068

7169
```
72-
Found 150 results:
70+
# Show all results (default)
71+
pt-snap query --template-use leak_detection
72+
73+
# Show only first 5
74+
pt-snap query --template-use leak_detection -n 5
75+
76+
# Show all results (explicit)
77+
pt-snap query --template-use leak_detection -n 0
78+
```
79+
80+
Example output (with `-n 2`):
81+
82+
```
83+
Found 150 results, showing 2:
7384
{'id': 1, 'address': '0x1000', 'size': 2048, ...}
74-
...
75-
... and 140 more
85+
{'id': 2, 'address': '0x2000', 'size': 4096, ...}
86+
... and 148 more (use -n to show more)
7687
```
7788

7889
## Template Architecture

‎docs/zh/querying.md‎

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -64,15 +64,26 @@ pt-snap query --template-use leak_detection --params '{"min_size": 1024}'
6464

6565
## 输出格式
6666

67-
结果以列表形式展示:
68-
- 显示前 10 条结果
69-
- 超过 10 条时,显示剩余数量
67+
默认情况下显示所有结果。使用 `-n` 限制显示行数:
7068

7169
```
72-
Found 150 results:
70+
# 显示所有结果(默认)
71+
pt-snap query --template-use leak_detection
72+
73+
# 仅显示前 5 条
74+
pt-snap query --template-use leak_detection -n 5
75+
76+
# 显示所有结果(显式)
77+
pt-snap query --template-use leak_detection -n 0
78+
```
79+
80+
示例输出(使用 `-n 2`):
81+
82+
```
83+
Found 150 results, showing 2:
7384
{'id': 1, 'address': '0x1000', 'size': 2048, ...}
74-
...
75-
... and 140 more
85+
{'id': 2, 'address': '0x2000', 'size': 4096, ...}
86+
... and 148 more (use -n to show more)
7687
```
7788

7889
## 模板架构

‎src/pt_snap_cli/cli.py‎

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,13 @@ def query_database(
210210
autocompletion=complete_template_names,
211211
),
212212
] = None,
213+
max_rows: Annotated[
214+
int | None,
215+
typer.Option(
216+
"-n",
217+
help="Maximum number of result rows to display (<= 0 for unlimited, default: unlimited)",
218+
),
219+
] = None,
213220
) -> None:
214221
"""Execute queries on the memory snapshot database.
215222
@@ -400,11 +407,13 @@ def query_database(
400407
results = executor.execute_template(template_use, query_params, device_id=target_device)
401408

402409
if results:
403-
typer.echo(f"Found {len(results)} results:")
404-
for row in results[:10]:
410+
effective_limit = max_rows if max_rows is not None and max_rows > 0 else len(results)
411+
display = results[:effective_limit]
412+
typer.echo(f"Found {len(results)} results, showing {len(display)}:")
413+
for row in display:
405414
typer.echo(f" {row}")
406-
if len(results) > 10:
407-
typer.echo(f" ... and {len(results) - 10} more")
415+
if effective_limit < len(results):
416+
typer.echo(f" ... and {len(results) - effective_limit} more (use -n to show more)")
408417
else:
409418
typer.echo("No results found.")
410419

‎src/pt_snap_cli/query/templates/basic/allocation.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@ queries:
4242
description: Sort direction (ASC or DESC)
4343
limit:
4444
type: int
45-
default: 1000
45+
default: -1
4646
required: false
47-
description: Maximum rows to return
47+
description: Maximum rows to return (-1 for unlimited)
4848
offset:
4949
type: int
5050
default: 0

‎src/pt_snap_cli/query/templates/basic/block.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,9 @@ queries:
7777
description: Sort direction (ASC or DESC)
7878
limit:
7979
type: int
80-
default: 100
80+
default: -1
8181
required: false
82-
description: Maximum rows to return
82+
description: Maximum rows to return (-1 for unlimited)
8383
offset:
8484
type: int
8585
default: 0

‎src/pt_snap_cli/query/templates/basic/event.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,9 @@ queries:
6767
description: Sort direction (ASC or DESC)
6868
limit:
6969
type: int
70-
default: 1000
70+
default: -1
7171
required: false
72-
description: Maximum rows to return
72+
description: Maximum rows to return (-1 for unlimited)
7373
offset:
7474
type: int
7575
default: 0

0 commit comments

Comments
 (0)