M56D in-hand reload

[cm13-issue-bot]

Testmerges

#10999: '[DNM] Fix of various plane related issues' by Blundir at commit f85a7153c4
#11075: 'Ticket Panel (Adminhelps & Mentorhelps)' by GeneriedJenelle at commit 4ad8d0cf87
#11902: 'implement pii scrubbing for sentry' by hry-gh at commit 759efb7bd1
#12174: 'Yautja Armor Sets' by realforest2001 at commit 90c66798ed
#10414: 'Port: Harm Intent uses Auto-Fire instead of PB' by MistChristmas at commit c70b0ced36
#10541: '[TM v.1.2] Warrior "Bulwark" Strain. (Feedback link in PR description)' by Venuska1117 at commit 205ef0b45e
#11161: 'Gas trap buff & neuro smoke tweaks' by Diegoflores31 at commit 92b29e6eb0
#12361: 'pride scarfs in loadout' by Detective-Google at commit 6ddcf88cb8
#10376: 'CIA Overhaul' by realforest2001 at commit cb35aca713
#12322: 'Fort McNeil - (Lowpop) Ground Map' by Steelpoint at commit ce3292659b
#12385: 'Disables Ordnance Technicans' by Steelpoint at commit 21a2725abf

Round ID

34597

Description of the bug

I reloaded my M5RD with a drum from in my hands, while it was disassembled, and it turned into a weird sprite saying "fix me". It fixed itself after I place and disassembled it again.

What's the difference with what should have happened?

It should have just put the drum in and reloaded, I guess.

How do we reproduce this bug?

1. Get an M56D heavy machine gun
2. Place the mount
3. Screw drive the mount
4. Place the machine gun on the mount
5. Screw drive it twice to turn it into an item
6. Pick it up, then use your other hand to load a drum into it

Attached logs

This is a M56D heavy machine gun. It is a huge item.
The top half of a M56D heavy machine gun post. However it ain't much use without the tripod.
The serial number is 7N6326H.
It has 700 out of 700 rounds. 

(The log for when I inspected the bugged sprite, the tiny image it displayed was a mess of pixels, though you can't see it now).

Additional details

• Author: Dr_dolphin12
• Admin: SeedyJatz
• Note: None

[noxvoxlux]

New Coder here,

This happens because the icon checks to update when loading the ammunition. It also updates the icon when a tripod is attached to it. It updates the state of the icon by adding "_tri" to it.

So when you add ammunition after the tripod is already attached, it does both. Making the item become "m56d_tri_tri", of which there is no sprite of.

This is what I can think of as a quick fix, but I'm not really experienced so maybe there's a way to adjust the whole "icon_state += _tri" thing. But by just reseting the icon_state to its initial seems to fix it.

/obj/item/device/m56d_gun/update_icon() //Lets generate the icon based on how much ammo it has.
	if(has_mount)
		icon_state += "_tri"
	if(rounds)
		overlays += mutable_appearance('icons/obj/items/weapons/guns/guns_by_faction/USCM/machineguns.dmi', "m56d_mag")
	return

/obj/item/device/m56d_gun/update_icon() //Lets generate the icon based on how much ammo it has.
	icon_state = initial(icon_state)
	if(has_mount)
		icon_state += "_tri"
	if(rounds)
		overlays += mutable_appearance('icons/obj/items/weapons/guns/guns_by_faction/USCM/machineguns.dmi', "m56d_mag")
	return